From: Ashish Kalra <ashish.kalra@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Steve Rutherford <srutherford@google.com>,
pbonzini@redhat.com, seanjc@google.com, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, joro@8bytes.org,
thomas.lendacky@amd.com, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, brijesh.singh@amd.com
Subject: Re: [PATCH v4 5/5] x86/kvm: Add guest support for detecting and enabling SEV Live Migration feature.
Date: Mon, 28 Jun 2021 19:34:41 +0000 [thread overview]
Message-ID: <20210628193441.GB23232@ashkalra_ubuntu_server> (raw)
In-Reply-To: <YNZXPEPxv54UmzNj@zn.tnic>
Hello Steve,
Do you have any final thoughts on this ?
I do need to resend the patch as per Boris's review below and i want to
do that before the merge window closes.
Thanks,
Ashish
On Sat, Jun 26, 2021 at 12:22:52AM +0200, Borislav Petkov wrote:
> On Fri, Jun 25, 2021 at 02:02:32PM -0700, Steve Rutherford wrote:
> > Boris, do you have any thoughts on the kexec aspect of this change?
>
> I'm suspecting you're asking here the wrong guy - I think you mean
> Paolo.
>
> But if I were to give some thoughts on this, I'd first request that this
> patch be split because it is doing a bunch of things at once.
>
> Then, I have no clue what "kexec support for SEV Live Migration" is. So
> this whole use case would need a lot more detailed explanation of all
> the moving parts and the "why" and the "because" and so on...
>
> But I'm no virt guy so perhaps this all makes sense to virt folks.
>
> Oh, and there's silly stuff like
>
> +static int __init setup_efi_kvm_sev_migration(void)
> {
> ...
> return true;
> }
>
> returning a bool but that's minor.
>
> --
> Regards/Gruss,
> Boris.
>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.kernel.org%2Ftglx%2Fnotes-about-netiquette&data=04%7C01%7CAshish.Kalra%40amd.com%7Cfca523e6b5b64a467b0408d93827ccc1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637602565894090530%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=JmqtrGxhzgVczPYWdCKEyRIxDDRcDI2Q%2FI83j2dxhGE%3D&reserved=0
next prev parent reply other threads:[~2021-06-28 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1623421410.git.ashish.kalra@amd.com>
2021-06-11 14:26 ` [PATCH v4 3/5] mm: x86: Invoke hypercall when page encryption status is changed Ashish Kalra
2021-06-11 14:28 ` [PATCH v4 4/5] EFI: Introduce the new AMD Memory Encryption GUID Ashish Kalra
2021-06-11 14:30 ` [PATCH v4 5/5] x86/kvm: Add guest support for detecting and enabling SEV Live Migration feature Ashish Kalra
2021-06-25 21:02 ` Steve Rutherford
2021-06-25 22:22 ` Borislav Petkov
2021-06-28 19:34 ` Ashish Kalra [this message]
2021-06-28 20:37 ` Steve Rutherford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628193441.GB23232@ashkalra_ubuntu_server \
--to=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=srutherford@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).