From: Thomas Huth <thuth@redhat.com>
To: Nicholas Piggin <npiggin@gmail.com>,
Andrew Jones <andrew.jones@linux.dev>
Cc: kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] Fix check-kerneldoc for out of tree builds
Date: Fri, 3 May 2024 08:29:02 +0200 [thread overview]
Message-ID: <19c4ed32-1ca7-4ba0-bdda-44918c5bce4a@redhat.com> (raw)
In-Reply-To: <20240503053612.970770-1-npiggin@gmail.com>
On 03/05/2024 07.36, Nicholas Piggin wrote:
> Search the source path rather than cwd.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> I leave ctags and cscope targets not working, since I don't use those
> tools and so don't have a test at hand. Being dev tools maybe(?) they
> would only get used in the source directory anyway, whereas check
> targets are useful for CI, etc.
>
> It should be trivial to fix them up if we want though.
>
> Thanks,
> Nick
> ---
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index b0f7ad08b..5b7998b79 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -150,4 +150,4 @@ tags:
> ctags -R
>
> check-kerneldoc:
> - find . -name '*.[ch]' -exec scripts/kernel-doc -none {} +
> + find $(SRCDIR) -name '*.[ch]' -exec scripts/kernel-doc -none {} +
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2024-05-03 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 5:36 [kvm-unit-tests PATCH] Fix check-kerneldoc for out of tree builds Nicholas Piggin
2024-05-03 6:29 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19c4ed32-1ca7-4ba0-bdda-44918c5bce4a@redhat.com \
--to=thuth@redhat.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).