From: Marc Zyngier <maz@kernel.org>
To: kvmarm@lists.linux.dev, Oliver Upton <oliver.upton@linux.dev>
Cc: James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v2] KVM: arm64: Destroy mpidr_data for 'late' vCPU creation
Date: Wed, 8 May 2024 16:43:55 +0100 [thread overview]
Message-ID: <171518298640.3700029.3551920564178293489.b4-ty@kernel.org> (raw)
In-Reply-To: <20240508071952.2035422-1-oliver.upton@linux.dev>
On Wed, 08 May 2024 07:19:52 +0000, Oliver Upton wrote:
> A particularly annoying userspace could create a vCPU after KVM has
> computed mpidr_data for the VM, either by racing against VGIC
> initialization or having a userspace irqchip.
>
> In any case, this means mpidr_data no longer fully describes the VM, and
> attempts to find the new vCPU with kvm_mpidr_to_vcpu() will fail. The
> fix is to discard mpidr_data altogether, as it is only a performance
> optimization and not required for correctness. In all likelihood KVM
> will recompute the mappings when KVM_RUN is called on the new vCPU.
>
> [...]
Applied to next, thanks!
[1/1] KVM: arm64: Destroy mpidr_data for 'late' vCPU creation
commit: ce5d2448eb8fe83aed331db53a08612286a137dd
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2024-05-08 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 7:19 [PATCH v2] KVM: arm64: Destroy mpidr_data for 'late' vCPU creation Oliver Upton
2024-05-08 15:43 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171518298640.3700029.3551920564178293489.b4-ty@kernel.org \
--to=maz@kernel.org \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).