From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] KVM: x86/mmu: Fix a largely theoretical race in kvm_mmu_track_write()
Date: Fri, 3 May 2024 14:32:24 -0700 [thread overview]
Message-ID: <171469177238.1010157.17892485185197174264.b4-ty@google.com> (raw)
In-Reply-To: <20240423193114.2887673-1-seanjc@google.com>
On Tue, 23 Apr 2024 12:31:14 -0700, Sean Christopherson wrote:
> Add full memory barriers in kvm_mmu_track_write() and account_shadowed()
> to plug a (very, very theoretical) race where kvm_mmu_track_write() could
> miss a 0->1 transition of indirect_shadow_pages and fail to zap relevant,
> *stale* SPTEs.
>
> Without the barriers, because modern x86 CPUs allow (per the SDM):
>
> [...]
Applied to kvm-x86 mmu.
[1/1] KVM: x86/mmu: Fix a largely theoretical race in kvm_mmu_track_write()
https://github.com/kvm-x86/linux/commit/226d9b8f1688
--
https://github.com/kvm-x86/linux/tree/next
prev parent reply other threads:[~2024-05-03 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 19:31 [PATCH v3] KVM: x86/mmu: Fix a largely theoretical race in kvm_mmu_track_write() Sean Christopherson
2024-05-03 21:32 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171469177238.1010157.17892485185197174264.b4-ty@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).