From: Amit Machhiwal <amachhiw@linux.ibm.com>
To: Vaibhav Jain <vaibhav@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicholas Piggin <npiggin@gmail.com>,
Vaidyanathan Srinivasan <svaidy@linux.ibm.com>,
"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
Jordan Niethe <jniethe5@gmail.com>,
"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>
Subject: Re: Re: [PATCH v2] KVM: PPC: Book3S HV: Fix L2 guest reboot failure due to empty 'arch_compat'
Date: Mon, 5 Feb 2024 23:39:12 +0530 [thread overview]
Message-ID: <z47adbiweldcumlq4uejggkfcvfaw5nrd7v3tbh2e3pcvzjot2@gourfue5ytbl> (raw)
In-Reply-To: <87h6img6g4.fsf@vajain21.in.ibm.com>
Hi Vaibhav,
Thanks for looking into the patch.
On 2024/02/05 11:05 PM, Vaibhav Jain wrote:
> Hi Amit,
>
> Thanks for the patch. Minor comment on the patch below:
>
> Amit Machhiwal <amachhiw@linux.ibm.com> writes:
>
> <snip>
>
> >
> > +static inline unsigned long map_pcr_to_cap(unsigned long pcr)
> > +{
> > + unsigned long cap = 0;
> > +
> > + switch (pcr) {
> > + case PCR_ARCH_300:
> > + cap = H_GUEST_CAP_POWER9;
> > + break;
> > + case PCR_ARCH_31:
> > + cap = H_GUEST_CAP_POWER10;
> Though CONFIG_CC_IMPLICIT_FALLTHROUGH and '-Wimplicit-fallthrough'
> doesnt explicitly flag this usage, please consider using the
> 'fallthrough;' keyword here.
>
> However you probably dont want this switch-case to fallthrough so please
> use a 'break' instead.
Sure, v3 on the way.
>
> > + default:
> > + break;
> > + }
> > +
> > + return cap;
> > +}
> > +
> >
> <snip>
>
> With the suggested change above
>
> Reviewed-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Thanks!
>
> --
> Cheers
> ~ Vaibhav
~Amit
prev parent reply other threads:[~2024-02-05 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 13:26 [PATCH v2] KVM: PPC: Book3S HV: Fix L2 guest reboot failure due to empty 'arch_compat' Amit Machhiwal
2024-02-05 13:39 ` Aneesh Kumar K.V
2024-02-05 17:35 ` Vaibhav Jain
2024-02-05 18:09 ` Amit Machhiwal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=z47adbiweldcumlq4uejggkfcvfaw5nrd7v3tbh2e3pcvzjot2@gourfue5ytbl \
--to=amachhiw@linux.ibm.com \
--cc=aneesh.kumar@kernel.org \
--cc=jniethe5@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=svaidy@linux.ibm.com \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).