From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Len Baker <len.baker@gmx.com>, Paul Mackerras <paulus@ozlabs.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Kees Cook <keescook@chromium.org>,
kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: Replace zero-length array with flexible array member
Date: Wed, 20 Oct 2021 23:28:49 +0000 [thread overview]
Message-ID: <20211020232849.GA1315641@embeddedor> (raw)
In-Reply-To: <bb4faf3a-9fe9-280b-cb4c-e4904b0b2a8f@embeddedor.com>
On Mon, Sep 20, 2021 at 07:05:07PM -0500, Gustavo A. R. Silva wrote:
>
>
> On 9/18/21 09:21, Len Baker wrote:
> > There is a regular need in the kernel to provide a way to declare having
> > a dynamically sized set of trailing elements in a structure. Kernel code
> > should always use "flexible array members" [1] for these cases. The
> > older style of one-element or zero-length arrays should no longer be
> > used[2].
> >
> > Also, make use of the struct_size() helper in kzalloc().
> >
> > [1] https://en.wikipedia.org/wiki/Flexible_array_member
> > [2] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
> >
> > Signed-off-by: Len Baker <len.baker@gmx.com>
>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
I'm taking this in my -next tree.
Thanks
--
Gustavo
prev parent reply other threads:[~2021-10-20 23:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 14:21 [PATCH] KVM: PPC: Replace zero-length array with flexible array member Len Baker
2021-09-21 0:05 ` Gustavo A. R. Silva
2021-10-20 23:28 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020232849.GA1315641@embeddedor \
--to=gustavoars@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=len.baker@gmx.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).