From: "Zhang, Xiantao" <xiantao.zhang@intel.com>
To: kvm-ia64@vger.kernel.org
Subject: RE: [PATCH -next] kvm: fix ia64 printk formats
Date: Thu, 15 Oct 2009 02:32:49 +0000 [thread overview]
Message-ID: <706158FABBBA044BAD4FE898A02E4BC201C9B81776@pdsmsx503.ccr.corp.intel.com> (raw)
In-Reply-To: <20091014151008.3d48b9fe.randy.dunlap@oracle.com>
Seems strict checks are applied to latest kernel. Okay to me. Thanks!
Acked-By Xiantao Zhang <xiantao.zhang@intel.com>
Xiantao
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix printk formats in ia64/kvm:
>
> arch/ia64/kvm/kvm-ia64.c:250: warning: format '%lx' expects type
> 'long unsigned int', but argument 2 has type 'uint64_t'
> arch/ia64/kvm/kvm-ia64.c:774: warning: format '%lx' expects type
> 'long unsigned int', but argument 2 has type 'uint64_t'
> arch/ia64/kvm/kvm_fw.c:151: warning: format '%ld' expects type 'long
> int', but argument 3 has type 's64' arch/ia64/kvm/kvm_fw.c:151:
> warning: format '%lx' expects type 'long unsigned int', but argument
> 4 has type 'u64' arch/ia64/kvm/kvm_fw.c:151: warning: format '%lx'
> expects type 'long unsigned int', but argument 5 has type 'u64'
> arch/ia64/kvm/kvm_fw.c:548: warning: format '%lx' expects type 'long
> unsigned int', but argument 2 has type 'u64'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Xiantao Zhang <xiantao.zhang@intel.com>
> ---
> arch/ia64/kvm/kvm-ia64.c | 4 ++--
> arch/ia64/kvm/kvm_fw.c | 9 +++++----
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> --- linux-next-20091014.orig/arch/ia64/kvm/kvm-ia64.c
> +++ linux-next-20091014/arch/ia64/kvm/kvm-ia64.c
> @@ -247,7 +247,7 @@ mmio:
> r = kvm_io_bus_write(&vcpu->kvm->mmio_bus, p->addr,
> p->size, &p->data);
> if (r)
> - printk(KERN_ERR"kvm: No iodevice found! addr:%lx\n", p->addr);
> + printk(KERN_ERR "kvm: No iodevice found! addr:%llx\n", p->addr);
> p->state = STATE_IORESP_READY;
>
> return 1;
> @@ -771,7 +771,7 @@ static struct kvm *kvm_alloc_kvm(void)
> kvm = (struct kvm *)(vm_base +
> offsetof(struct kvm_vm_data, kvm_vm_struct));
> kvm->arch.vm_base = vm_base;
> - printk(KERN_DEBUG"kvm: vm's data area:0x%lx\n", vm_base);
> + printk(KERN_DEBUG "kvm: vm's data area:0x%llx\n", vm_base);
>
> return kvm;
> }
> --- linux-next-20091014.orig/arch/ia64/kvm/kvm_fw.c
> +++ linux-next-20091014/arch/ia64/kvm/kvm_fw.c
> @@ -146,9 +146,10 @@ static struct ia64_pal_retval pal_cache_
> &result.v0);
> local_irq_restore(psr);
> if (result.status != 0)
> - printk(KERN_ERR"vcpu:%p crashed due to cache_flush err:%ld"
> + printk(KERN_ERR "vcpu:%p crashed due to cache_flush err:%ld"
> "in1:%lx,in2:%lx\n",
> - vcpu, result.status, gr29, gr30);
> + vcpu, (long)result.status,
> + (unsigned long)gr29, (unsigned long)gr30);
>
> #if 0
> if (gr29 = PAL_CACHE_TYPE_COHERENT) {
> @@ -544,8 +545,8 @@ int kvm_pal_emul(struct kvm_vcpu *vcpu,
> break;
> default:
> INIT_PAL_STATUS_UNIMPLEMENTED(result);
> - printk(KERN_WARNING"kvm: Unsupported pal call,"
> - " index:0x%lx\n", gr28);
> + printk(KERN_WARNING "kvm: Unsupported pal call,"
> + " index:0x%lx\n", (unsigned long)gr28);
> }
> set_pal_result(vcpu, result);
> return ret;
prev parent reply other threads:[~2009-10-15 2:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 22:10 [PATCH -next] kvm: fix ia64 printk formats Randy Dunlap
2009-10-15 2:32 ` Zhang, Xiantao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=706158FABBBA044BAD4FE898A02E4BC201C9B81776@pdsmsx503.ccr.corp.intel.com \
--to=xiantao.zhang@intel.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).