From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian
Date: Wed, 21 Apr 2010 11:15:13 +0000 [thread overview]
Message-ID: <4BCEDE41.1070100@redhat.com> (raw)
In-Reply-To: <20100420200043.956302db.yoshikawa.takuya@oss.ntt.co.jp>
On 04/20/2010 02:00 PM, Takuya Yoshikawa wrote:
> We are now using generic___set_le_bit() to make dirty bitmaps le.
> Though this works well, we have to replace __set_bit() to appropriate
> uaccess function to move dirty bitmaps to user space. So this patch
> splits generic___set_le_bit() and prepares for that.
>
>
> +static int __mark_page_dirty(unsigned long nr,
> + unsigned long *dirty_bitmap)
> +{
> +#ifdef __BIG_ENDIAN
> + nr = nr ^ BITOP_LE_SWIZZLE;
> +#endif
> + __set_bit(nr, dirty_bitmap);
>
Why not introduce __set_le_bit_user() along with __set_bit_user()? kvm
shouldn't do endian corrections when they can be done in generic code.
> +}
> +
> void mark_page_dirty(struct kvm *kvm, gfn_t gfn)
> {
> struct kvm_memory_slot *memslot;
> @@ -1203,11 +1212,8 @@ void mark_page_dirty(struct kvm *kvm, gfn_t gfn)
> if (memslot&& memslot->dirty_bitmap) {
> unsigned long rel_gfn = gfn - memslot->base_gfn;
>
> - /* avoid RMW */
> - if (!generic_test_le_bit(rel_gfn, memslot->dirty_bitmap)) {
> - generic___set_le_bit(rel_gfn, memslot->dirty_bitmap);
> - memslot->is_dirty = true;
> - }
>
You're also dropping the RMW avoidance. This is fine, but deserves at
least a note in the changelog (or a separate patch).
> + __mark_page_dirty(rel_gfn, memslot->dirty_bitmap);
> + memslot->is_dirty = true;
> }
> }
>
>
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-04-21 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 10:57 [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian Takuya Yoshikawa
2010-04-20 11:00 ` [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian issues explicitly Alexander Graf
2010-04-20 11:20 ` [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian Takuya Yoshikawa
2010-04-21 11:15 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCEDE41.1070100@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).