From: Jes Sorensen <jes@sgi.com>
To: kvm-ia64@vger.kernel.org
Subject: [patch] ia64 vcpu_reset() do not call kmalloc() with irqs disabled
Date: Fri, 17 Apr 2009 14:43:27 +0000 [thread overview]
Message-ID: <49E8958F.5060607@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 141 bytes --]
Hi,
Here we go again, another case where we were calling kmalloc() through
vcpu_reset() while local interrupts were disabled.
Cheers,
Jes
[-- Attachment #2: 0006-kvm-ia64-vcpu-reset-sleep.patch --]
[-- Type: text/x-patch, Size: 695 bytes --]
Restore local irq enabled state before calling kvm_arch_vcpu_init(),
which calls kmalloc(GFP_KERNEL).
Signed-off-by: Jes Sorensen <jes@sgi.com>
---
arch/ia64/kvm/kvm-ia64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.git/arch/ia64/kvm/kvm-ia64.c
===================================================================
--- linux-2.6.git.orig/arch/ia64/kvm/kvm-ia64.c
+++ linux-2.6.git/arch/ia64/kvm/kvm-ia64.c
@@ -1919,6 +1919,7 @@
long psr;
local_irq_save(psr);
r = kvm_insert_vmm_mapping(vcpu);
+ local_irq_restore(psr);
if (r)
goto fail;
@@ -1931,7 +1932,6 @@
kvm_purge_vmm_mapping(vcpu);
r = 0;
fail:
- local_irq_restore(psr);
return r;
}
next reply other threads:[~2009-04-17 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 14:43 Jes Sorensen [this message]
2009-04-19 13:16 ` [patch] ia64 vcpu_reset() do not call kmalloc() with irqs Zhang, Xiantao
2009-04-20 7:58 ` [patch] ia64 vcpu_reset() do not call kmalloc() with irqs disabled Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E8958F.5060607@sgi.com \
--to=jes@sgi.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).