From: Gleb Natapov <gleb@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH 0/4] decouple vcpu index from apic id
Date: Tue, 09 Jun 2009 05:26:58 +0000 [thread overview]
Message-ID: <20090609052658.GN27210@redhat.com> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC201BD6C62FD@pdsmsx503.ccr.corp.intel.com>
On Tue, Jun 09, 2009 at 10:30:01AM +0800, Zhang, Xiantao wrote:
> Avi Kivity wrote:
> > Gleb Natapov wrote:
> >> Currently vcpu_id is used as an index into vcpus array and as apic id
> >> on x86. This is incorrect since apic ids not have to be continuous
> >> (they can also encode cpu hierarchy information) and may have values
> >> bigger then vcpu array in case of x2apic. This series removes use of
> >> vcpu_id as vcpus array index. Each architecture may use it how it
> >> sees fit. x86 uses it as apic id.
> >>
> >>
> >
> > Apart from my minor comments, this looks good, but I'd like to get
> > acks from arch maintainers to avoid surprises.
> >
> > Xiantao, does setting the bsp id make sense for ia64?
>
> Make sense for ia64, if bsp id is set to 0.
> But still have one comment about the patchset, in Patch[3/4], online_vcpus in kvm structure is introduced, but it should have the conflicts with arch.online_vcpus for ia64. So I think it should be fixed before check-in.
Patch 4/4 removes use of arch.online_vcpus. online_vcpus are used instead.
I'll move arch.online_vcpus removal to patch 3/4 instead.
--
Gleb.
prev parent reply other threads:[~2009-06-09 5:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 2:30 [PATCH 0/4] decouple vcpu index from apic id Zhang, Xiantao
2009-06-09 5:26 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090609052658.GN27210@redhat.com \
--to=gleb@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).