From: YueHaibing <yuehaibing@huawei.com>
To: Jarkko Sakkinen <jarkko@kernel.org>, <dhowells@redhat.com>,
<paul@paul-moore.com>, <jmorris@namei.org>, <serge@hallyn.com>
Cc: <keyrings@vger.kernel.org>,
<linux-security-module@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 -next] keys: Remove unused extern declarations
Date: Sat, 29 Jul 2023 10:40:40 +0800 [thread overview]
Message-ID: <a6826fc1-3319-9ca6-4c25-61703424f052@huawei.com> (raw)
In-Reply-To: <CUE18VURE744.1E29WQ8EU666G@seitikki>
On 2023/7/29 2:55, Jarkko Sakkinen wrote:
> On Mon Jul 24, 2023 at 2:47 PM UTC, YueHaibing wrote:
>> Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
>> iterate_over_keyring() is never used, so can be removed.
>>
>> And commit b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
>> left behind keyring_search_instkey().
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Please use the fixes tag properly.
OK, will add fixes tag in v3.
>
>> ---
>> v2: Also remove keyring_search_instkey()
>> ---
>> security/keys/internal.h | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/security/keys/internal.h b/security/keys/internal.h
>> index 3c1e7122076b..471cf36dedc0 100644
>> --- a/security/keys/internal.h
>> +++ b/security/keys/internal.h
>> @@ -109,13 +109,6 @@ extern void __key_link_end(struct key *keyring,
>> extern key_ref_t find_key_to_update(key_ref_t keyring_ref,
>> const struct keyring_index_key *index_key);
>>
>> -extern struct key *keyring_search_instkey(struct key *keyring,
>> - key_serial_t target_id);
>> -
>> -extern int iterate_over_keyring(const struct key *keyring,
>> - int (*func)(const struct key *key, void *data),
>> - void *data);
>> -
>> struct keyring_search_context {
>> struct keyring_index_key index_key;
>> const struct cred *cred;
>> --
>> 2.34.1
>
>
> BR, Jarkko
> .
>
prev parent reply other threads:[~2023-07-29 2:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 14:47 [PATCH v2 -next] keys: Remove unused extern declarations YueHaibing
2023-07-28 18:55 ` Jarkko Sakkinen
2023-07-29 2:40 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6826fc1-3319-9ca6-4c25-61703424f052@huawei.com \
--to=yuehaibing@huawei.com \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).