From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Joachim Vandersmissen" <git@jvdsn.com>,
"Eric Biggers" <ebiggers@kernel.org>
Cc: <linux-crypto@vger.kernel.org>, <keyrings@vger.kernel.org>,
<stable@vger.kernel.org>, "Simo Sorce" <simo@redhat.com>,
"David Howells" <dhowells@redhat.com>,
"kernel test robot" <oliver.sang@intel.com>
Subject: Re: [PATCH] KEYS: asymmetric: Add missing dependencies of FIPS_SIGNATURE_SELFTEST
Date: Wed, 24 Apr 2024 00:56:21 +0300 [thread overview]
Message-ID: <D0RU64GRK26M.3TH8TUG9PCKPT@kernel.org> (raw)
In-Reply-To: <908bc808-f8bd-4cc2-8644-c6c84e8cd4ea@jvdsn.com>
On Tue Apr 23, 2024 at 7:02 AM EEST, Joachim Vandersmissen wrote:
> Hi Eric,
>
> On 4/22/24 4:10 PM, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Since the signature self-test uses RSA and SHA-256, it must only be
> > enabled when those algorithms are enabled. Otherwise it fails and
> > panics the kernel on boot-up.
>
> I actually submitted two related patch recently which change the
> structure of the PKCS#7 self-tests and add an ECDSA self-test. See
> "[PATCH v2 1/2] certs: Move RSA self-test data to separate file" and
> "[PATCH v2 2/2] certs: Add ECDSA signature verification self-test" on
> 2024-04-20. The explicit dependency on CRYPTO_RSA shouldn't be necessary
> with those patches (I think).
>
> However, I didn't consider CRYPTO_SHA256 there. I think it can remain
> since both the RSA and proposed ECDSA self-tests use SHA-256.
Their how in my master branch, I'll mirror them to linux-next in day
or two.
BR, Jarkko
next prev parent reply other threads:[~2024-04-23 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 21:10 [PATCH] KEYS: asymmetric: Add missing dependencies of FIPS_SIGNATURE_SELFTEST Eric Biggers
2024-04-23 4:02 ` Joachim Vandersmissen
2024-04-23 21:56 ` Jarkko Sakkinen [this message]
2024-04-23 21:52 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0RU64GRK26M.3TH8TUG9PCKPT@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=git@jvdsn.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=simo@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).