From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Roman Smirnov" <r.smirnov@omp.ru>,
"David Howells" <dhowells@redhat.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Andrew Zaborowski" <andrew.zaborowski@intel.com>
Cc: "keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>,
"Sergey Shtylyov" <s.shtylyov@omp.ru>
Subject: Re: [PATCH] KEYS: prevent NULL pointer dereference in find_asymmetric_key()
Date: Thu, 21 Mar 2024 18:12:56 +0200 [thread overview]
Message-ID: <CZZK77BY3FK4.2WMP1X5H9GTL1@kernel.org> (raw)
In-Reply-To: <7fd0f2a8252d4a6aa295adc1e76bc0e2@omp.ru>
On Wed Mar 20, 2024 at 10:21 AM EET, Roman Smirnov wrote:
> On Tue, 19 Mar 2024 22:14:22 +0200 Jarkko Sakkinen wrote:
> > On Tue Mar 19, 2024 at 4:44 PM EET, Roman Smirnov wrote:
> > > On Tue, 19 Mar 2024 01:39:00 +0200 Jarkko Sakkinen wrote:
> > > > On Fri Mar 15, 2024 at 12:33 PM EET, Roman Smirnov wrote:
> [...]
> > > > >
> > > > > Found by Linux Verification Center (linuxtesting.org) with Svace.
> > > >
> > > > I'm not sure if this should be part of the commit message.
> > >
> > > I have already submitted patches with this line, some have been
> > > accepted. It is important for the Linux Verification Center to mark
> > > patches as closing issues found with Svace.
> > >
> > > > >
> > > > > Fixes: 7d30198ee24f ("keys: X.509 public key issuer lookup without AKID")
> > > > > Suggested-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> > > >
> > > > Should be reported-by.
> > >
> > > The suggested-by tag belongs to Sergey because he suggested the fix,
> > > subject/description of the patch. The tag reported-by belongs to
> > > Svace tool.
> >
> > 1. I did not see any reported-by tags in this which is requirement.
> > 2. Who did find the issue using that tool? I don't put reported-by to
> > GDB even if I use that find the bug.
>
> Svace is an automated bug finding tool. This error was found during
> source code analysis by the program, so the tag reported-by does not
> belong to any person. I don't know what to do in such a situation,
> but write something like:
>
> Reported-by: Svace
>
> would be weird. I think that the line "Found by Linux ... with Svace"
> could be a substitute for the tag.
I'd prefer a person here that used the tool as it is not korg hosted
automated tool.
BR, Jarkko
prev parent reply other threads:[~2024-03-21 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 10:33 [PATCH] KEYS: prevent NULL pointer dereference in find_asymmetric_key() Roman Smirnov
2024-03-18 23:39 ` Jarkko Sakkinen
2024-03-19 14:44 ` Roman Smirnov
2024-03-19 20:14 ` Jarkko Sakkinen
2024-03-20 8:21 ` Roman Smirnov
2024-03-21 16:12 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZZK77BY3FK4.2WMP1X5H9GTL1@kernel.org \
--to=jarkko@kernel.org \
--cc=andrew.zaborowski@intel.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=r.smirnov@omp.ru \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).