Keyrings Archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: dhowells@redhat.com, Yue Haibing <yuehaibing@huawei.com>,
	jmorris@namei.org, serge@hallyn.com, keyrings@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 -next] keys: Remove unused extern declarations
Date: Wed, 13 Sep 2023 15:46:30 -0400	[thread overview]
Message-ID: <CAHC9VhRA-V==Q-H_0V=-ic4eBrVJtDfpUvUX9Sp80SRt3DQUTQ@mail.gmail.com> (raw)
In-Reply-To: <CVI1FHKRSG47.2CV547I19B9ZT@suppilovahvero>

On Wed, Sep 13, 2023 at 3:31 PM Jarkko Sakkinen <jarkko@kernel.org> wrote:
> On Wed Sep 13, 2023 at 9:00 PM EEST, Paul Moore wrote:
> > On Mon, Aug 7, 2023 at 5:46 PM Paul Moore <paul@paul-moore.com> wrote:
> > > On Fri, Jul 28, 2023 at 10:40 PM Yue Haibing <yuehaibing@huawei.com> wrote:
> > > >
> > > > From: YueHaibing <yuehaibing@huawei.com>
> > > >
> > > > Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> > > > iterate_over_keyring() is never used, so can be removed.
> > > >
> > > > And commit b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
> > > > left behind keyring_search_instkey().
> > > >
> > > > Fixes: b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> > > > Fixes: b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
> > > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > > > ---
> > > > v3: Add Fixes tag
> > > > v2: Also remove keyring_search_instkey()
> > > > ---
> > > >  security/keys/internal.h | 7 -------
> > > >  1 file changed, 7 deletions(-)
> > >
> > > Reviewed-by: Paul Moore <paul@paul-moore.com>
> >
> > Jarkko or David, please merge this or explain what is wrong with this patch.
>
> Sorry, I was aiming to pick this, and thanks for reminding.
>
> Applied.

Thanks.

-- 
paul-moore.com

      reply	other threads:[~2023-09-13 19:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-29  2:40 [PATCH v3 -next] keys: Remove unused extern declarations Yue Haibing
2023-08-07 21:46 ` Paul Moore
2023-09-13 18:00   ` Paul Moore
2023-09-13 19:31     ` Jarkko Sakkinen
2023-09-13 19:46       ` Paul Moore [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHC9VhRA-V==Q-H_0V=-ic4eBrVJtDfpUvUX9Sp80SRt3DQUTQ@mail.gmail.com' \
    --to=paul@paul-moore.com \
    --cc=dhowells@redhat.com \
    --cc=jarkko@kernel.org \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).