From: Nicholas Vinson <nvinson234@gmail.com>
To: Jarkko Sakkinen <jarkko@kernel.org>,
keyrings@vger.kernel.org, dhowells@redhat.com
Subject: Re: [keyutils] Remove undefined functions afrom version.lds
Date: Mon, 4 Mar 2024 01:06:14 -0500 [thread overview]
Message-ID: <22c30a36-5e52-4602-b24e-9d02d137ccfa@gmail.com> (raw)
In-Reply-To: <22b2df74-ca8d-419d-8d5c-3780c1d6e26e@gmail.com>
On 1/3/24 10:00, Nicholas Vinson wrote:
>
> On 1/3/24 09:12, Jarkko Sakkinen wrote:
>> On Wed Dec 27, 2023 at 11:35 PM EET, Nicholas Vinson wrote:
>>> Functions keyctl_restrict() and keyctl_dh_compute_kdf_alloc() are
>>> nodefined. Their inclusion in version.lds causes clang/llvm LTO
>> What does "nodefined" mean?
>
> It's a typographical error I failed to catch before sending the email.It
> is supposed to say "not defined".
>
>>> optimizations to fail with error messages similar to
>>>
>>> error: version script assignment of KEYUTILS_1.7 to symbol
>>> keyctl_restrict failed: symbol not defined
>>>
>>> This patch fixes the issue by removing the symbol names from
>>> version.lds.
>>>
>>> Fixes Gentoo bug 914637 (https://bugs.gentoo.org/914637)
>> I wonder if we can uses here "Closes: <url>" similarly as with
>> kernel bugzilla (question to more broad audience)?
>>
>>> Signed-off-by: Nicholas Vinson<nvinson234@gmail.com>
>>> ---
>>> version.lds | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/version.lds b/version.lds
>>> index 6c34adf..6186fb6 100644
>>> --- a/version.lds
>>> +++ b/version.lds
>>> @@ -76,9 +76,7 @@ KEYUTILS_1.6 {
>>> KEYUTILS_1.7 {
>>> /* management functions */
>>> - keyctl_restrict;
>>> keyctl_dh_compute_kdf;
>>> - keyctl_dh_compute_kdf_alloc;
>>> } KEYUTILS_1.6;
>> BR, Jarkko
May I get a status update for this PR please?
Thanks,
Nicholas Vinson
prev parent reply other threads:[~2024-03-04 6:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 21:35 [keyutils] Remove undefined functions afrom version.lds Nicholas Vinson
2023-12-28 1:56 ` Ben Boeckel
2023-12-28 2:20 ` Nicholas Vinson
2024-01-03 14:16 ` Jarkko Sakkinen
2024-01-03 14:15 ` Jarkko Sakkinen
2024-01-03 14:12 ` Jarkko Sakkinen
2024-01-03 15:00 ` Nicholas Vinson
2024-03-04 6:06 ` Nicholas Vinson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22c30a36-5e52-4602-b24e-9d02d137ccfa@gmail.com \
--to=nvinson234@gmail.com \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).