From: Greg KH <gregkh@linuxfoundation.org>
To: sedat.dilek@gmail.com
Cc: David Howells <dhowells@redhat.com>,
ceph-devel@vger.kernel.org, davem@davemloft.net, eadavis@qq.com,
edumazet@google.com, horms@kernel.org, jaltman@auristor.com,
jarkko@kernel.org, jlayton@redhat.com, keyrings@vger.kernel.org,
kuba@kernel.org, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
marc.dionne@auristor.com, markus.suvanto@gmail.com,
netdev@vger.kernel.org, pabeni@redhat.com, pengfei.xu@intel.com,
smfrench@gmail.com, stable@vger.kernel.org,
torvalds@linux-foundation.org, wang840925@gmail.com,
sashal@kernel.org, pvorel@suse.cz
Subject: Re: [PATCH] keys, dns: Fix size check of V1 server-list header
Date: Mon, 22 Jan 2024 07:02:32 -0800 [thread overview]
Message-ID: <2024012218-unlocking-pushy-c7e6@gregkh> (raw)
In-Reply-To: <CA+icZUUc_0M_6JU3dZzVqrUUrWJceY1uD8dO2yFMCwtHtkaa_Q@mail.gmail.com>
On Mon, Jan 22, 2024 at 08:32:20AM +0100, Petr Vorel wrote:
> From: Sedat Dilek <sedat.dilek@gmail.com>
>
> On Wed, Jan 10, 2024 at 10:12 PM David Howells <dhowells@redhat.com> wrote:
> >
> >
> > Fix the size check added to dns_resolver_preparse() for the V1 server-list
> > header so that it doesn't give EINVAL if the size supplied is the same as
> > the size of the header struct (which should be valid).
> >
> > This can be tested with:
> >
> > echo -n -e '\0\0\01\xff\0\0' | keyctl padd dns_resolver desc @p
> >
> > which will give "add_key: Invalid argument" without this fix.
> >
> > Fixes: 1997b3cb4217 ("keys, dns: Fix missing size check of V1 server-list header")
>
> [ CC stable@vger.kernel.org ]
>
> Your (follow-up) patch is now upstream.
>
> https://git.kernel.org/linus/acc657692aed438e9931438f8c923b2b107aebf9
>
> This misses CC: Stable Tag as suggested by Linus.
>
> Looks like linux-6.1.y and linux-6.6.y needs it, too.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.6.11&id=da89365158f6f656b28bcdbcbbe9eaf97c63c474
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.1.72&id=079eefaecfd7bbb8fcc30eccb0dfdf50c91f1805
And 5.10.y and 5.15.y. Now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2024-01-22 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 21:11 [PATCH] keys, dns: Fix size check of V1 server-list header David Howells
2024-01-11 5:58 ` Sedat Dilek
2024-01-22 7:32 ` Petr Vorel
2024-01-22 11:01 ` Sedat Dilek
2024-01-22 11:31 ` Sedat Dilek
2024-01-22 15:02 ` Greg KH [this message]
2024-01-11 13:19 ` Simon Horman
2024-01-13 20:40 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024012218-unlocking-pushy-c7e6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ceph-devel@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=eadavis@qq.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jaltman@auristor.com \
--cc=jarkko@kernel.org \
--cc=jlayton@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=markus.suvanto@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pengfei.xu@intel.com \
--cc=pvorel@suse.cz \
--cc=sashal@kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=smfrench@gmail.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=wang840925@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).