From: Baoquan He <bhe@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yuntao Wang <ytcoode@gmail.com>,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
Vivek Goyal <vgoyal@redhat.com>, Dave Young <dyoung@redhat.com>,
Zhen Lei <thunder.leizhen@huawei.com>
Subject: Re: [PATCH] crash_core: Fix the check for whether crashkernel is from high memory
Date: Mon, 11 Dec 2023 13:53:12 +0800 [thread overview]
Message-ID: <ZXajyFKrSp5oRKwf@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20231209143418.92f02de6b6c6db2b7b3b1815@linux-foundation.org>
On 12/09/23 at 02:34pm, Andrew Morton wrote:
> On Sat, 9 Dec 2023 22:14:38 +0800 Yuntao Wang <ytcoode@gmail.com> wrote:
>
> > If crash_base is equal to CRASH_ADDR_LOW_MAX, it also indicates that
> > the crashkernel memory is allocated from high memory. However, the
> > current check only considers the case where crash_base is greater than
> > CRASH_ADDR_LOW_MAX. Fix it.
> >
> > This patch also includes some minor cleanups.
>
> Can we please include a description of the runtime effects of this
> change? ie, what happens now and under what circumstances, and how
> does the fix alter these things?
This is a good catch. Guess it's observed from code exploring.
The runtime effects is that crashkernel high memory is successfully
reserved, whereas the crashkernel low memory is bypassed in this
case, then kdump kernel bootup will fail because of no low memory
under 4G.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2023-12-11 5:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 14:14 [PATCH] crash_core: Fix the check for whether crashkernel is from high memory Yuntao Wang
2023-12-09 22:34 ` Andrew Morton
2023-12-10 4:05 ` [PATCH v2] " Yuntao Wang
2023-12-11 5:53 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXajyFKrSp5oRKwf@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
--cc=vgoyal@redhat.com \
--cc=ytcoode@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).