From: Joel Granados <j.granados@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Luis Chamberlain <mcgrof@kernel.org>, <josh@joshtriplett.org>,
Kees Cook <keescook@chromium.org>,
Eric Biederman <ebiederm@xmission.com>,
Iurii Zaikin <yzaikin@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Petr Mladek <pmladek@suse.com>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Balbir Singh <bsingharora@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, <linux-kernel@vger.kernel.org>,
<kexec@lists.infradead.org>, <linux-fsdevel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
<tools@kernel.org>
Subject: Re: [PATCH v3 00/10] sysctl: Remove sentinel elements from kernel dir
Date: Wed, 24 Apr 2024 09:55:07 +0200 [thread overview]
Message-ID: <20240424075507.ggdmj7hg2xihmbq6@joelS2.panther.com> (raw)
In-Reply-To: <1804aebc-68a5-4bd8-b42e-e06ce82f7355@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 2131 bytes --]
On Mon, Apr 22, 2024 at 05:07:59PM +0200, Krzysztof Kozlowski wrote:
> On 22/04/2024 16:57, Konstantin Ryabitsev wrote:
> > On Mon, Apr 22, 2024 at 04:49:27PM +0200, Krzysztof Kozlowski wrote:
> >>>> These commits remove the sentinel element (last empty element) from
> >>>> the
> >>>> sysctl arrays of all the files under the "kernel/" directory that use a
> >>>> sysctl array for registration. The merging of the preparation patches
> >>>> [1] to mainline allows us to remove sentinel elements without changing
> >>>> behavior. This is safe because the sysctl registration code
> >>>> (register_sysctl() and friends) use the array size in addition to
> >>>> checking for a sentinel [2].
> >>>
> >>> Hi,
> >>>
> >>> looks like *this* "patch" made it to the sysctl tree [1], breaking b4
> >>> for everyone else (as there's a "--- b4-submit-tracking ---" magic in
> >>> the tree history now) on next-20240422
> >>>
> >>> Please drop it (again, I'm only talking about this empty cover letter).
> >>
> >> Just to clarify, in case it is not obvious:
> >> Please *do not merge your own trees* into kernel.org repos. Instead use
> >> b4 shazam to pick up entire patchset, even if it is yours. b4 allows to
> >> merge/apply also the cover letter, if this is your intention.
> >>
> >> With b4 shazam you would get proper Link tags and not break everyone's
> >> b4 workflow on next. :/
> >
> > I was expecting this to happen at some point. :/
> >
> > Note, that you can still use b4 and merge your own trees, but you need
> > to switch to using a different cover letter strategy:
> >
> > [b4]
> > prep-cover-strategy = branch-description
>
> Yes, but you still won't have:
> 1. Link tags
> 2. Nice thank-you letters
> 3. Auto-collecting review/tested/ack tags
>
> So sure, maintainer can even cherry-pick patches, use patch or manually
> edit git objects and then update git refs, but that's not the point. :)
>
> Just use b4 shazam, it's so awesome tool.
I'll try this out going forward (instead of chaning the cover letter
strategy)
Thx again.
Best
--
Joel Granados
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2024-04-30 18:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240328154421eucas1p14e2a43b2894dd706aa4e2affc54f3143@eucas1p1.samsung.com>
2024-03-28 15:44 ` [PATCH v3 00/10] sysctl: Remove sentinel elements from kernel dir Joel Granados via B4 Relay
2024-03-28 15:44 ` [PATCH v3 01/10] kernel misc: Remove the now superfluous sentinel elements from ctl_table array Joel Granados via B4 Relay
2024-03-28 15:44 ` [PATCH v3 02/10] umh: " Joel Granados via B4 Relay
2024-03-28 15:44 ` [PATCH v3 03/10] ftrace: " Joel Granados via B4 Relay
2024-03-28 15:44 ` [PATCH v3 04/10] timekeeping: " Joel Granados via B4 Relay
2024-03-28 15:44 ` [PATCH v3 05/10] seccomp: " Joel Granados via B4 Relay
2024-03-28 15:44 ` [PATCH v3 06/10] scheduler: " Joel Granados via B4 Relay
2024-04-09 9:02 ` Valentin Schneider
2024-03-28 15:44 ` [PATCH v3 07/10] printk: " Joel Granados via B4 Relay
2024-03-28 15:44 ` [PATCH v3 08/10] kprobes: " Joel Granados via B4 Relay
2024-03-28 15:44 ` [PATCH v3 09/10] delayacct: " Joel Granados via B4 Relay
2024-03-28 15:44 ` [PATCH v3 10/10] bpf: " Joel Granados via B4 Relay
2024-04-15 13:12 ` [PATCH v3 00/10] sysctl: Remove sentinel elements from kernel dir Joel Granados
2024-04-22 14:27 ` Konrad Dybcio
2024-04-22 14:49 ` Krzysztof Kozlowski
2024-04-22 14:57 ` Konstantin Ryabitsev
2024-04-22 15:07 ` Krzysztof Kozlowski
2024-04-24 7:55 ` Joel Granados [this message]
2024-04-24 7:46 ` Joel Granados
2024-04-24 7:41 ` Joel Granados
2024-04-24 7:52 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424075507.ggdmj7hg2xihmbq6@joelS2.panther.com \
--to=j.granados@samsung.com \
--cc=andrii@kernel.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=bsingharora@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dietmar.eggemann@arm.com \
--cc=ebiederm@xmission.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=jolsa@kernel.org \
--cc=josh@joshtriplett.org \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=kexec@lists.infradead.org \
--cc=konrad.dybcio@linaro.org \
--cc=konstantin@linuxfoundation.org \
--cc=kpsingh@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=mcgrof@kernel.org \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=sdf@google.com \
--cc=senozhatsky@chromium.org \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=tools@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wad@chromium.org \
--cc=yonghong.song@linux.dev \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).