kexec.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: chenhaixiang <chenhaixiang3@huawei.com>
Cc: kexec@lists.infradead.org, louhongxiang@huawei.com,
	fangchuangchuang@huawei.com, wangbin224@huawei.com,
	bhe@redhat.com
Subject: Re: [PATCH] crashdump-x86.c:Add a check for the crash kernel range in exclude_region()
Date: Tue, 23 Apr 2024 11:18:18 +0100	[thread overview]
Message-ID: <20240423101818.GI42092@kernel.org> (raw)
In-Reply-To: <20240321113317.1231648-1-chenhaixiang3@huawei.com>

On Thu, Mar 21, 2024 at 07:33:17PM +0800, chenhaixiang wrote:
> In some cases, such as start < mstart < mend < end when exclude_region(),
> this results in crash_memory_range[i].end becoming less than
> crash_memory_range[i].start, leading to incorrect address ranges.
> Adding a range check should be necessary.
> 
> Signed-off-by: chenhaixiang chenhaixiang3@huawei.com

Hi,

Given the discussion at [1] I am assuming this patch should not go in.
Please correct me if I am wrong.

[1] https://lore.kernel.org/all/8606fd02d6de4eb3b7c80e4ce3449458@huawei.com/

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2024-04-23 10:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21 11:33 [PATCH] crashdump-x86.c:Add a check for the crash kernel range in exclude_region() chenhaixiang
2024-04-23 10:18 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240423101818.GI42092@kernel.org \
    --to=horms@kernel.org \
    --cc=bhe@redhat.com \
    --cc=chenhaixiang3@huawei.com \
    --cc=fangchuangchuang@huawei.com \
    --cc=kexec@lists.infradead.org \
    --cc=louhongxiang@huawei.com \
    --cc=wangbin224@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).