From: Simon Horman <horms@kernel.org>
To: Jiri Bohac <jbohac@suse.cz>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] kexec: don't use kexec_file_load on XEN
Date: Thu, 25 Jan 2024 17:02:45 +0000 [thread overview]
Message-ID: <20240125170245.GA245752@kernel.org> (raw)
In-Reply-To: <Zaa5dwoUi4WnrCMA@dwarf.suse.cz>
On Tue, Jan 16, 2024 at 06:14:31PM +0100, Jiri Bohac wrote:
> Since commit 29fe5067ed07 ("kexec: make -a the default")
> kexec tries the kexec_file_load syscall first and only falls back to kexec_load on
> selected error codes.
>
> This effectively breaks kexec on XEN, unless -c is pecified to force the kexec_load
> syscall.
>
> The XEN-specific functions (xen_kexec_load / xen_kexec_unload) are only called
> from my_load / k_unload, i.e. the kexec_load code path.
>
> With -p (panic kernel) kexec_file_load on XEN fails with -EADDRNOTAVAIL (crash
> kernel reservation is ignored by the kernel on XEN), which is not in the list
> of return codes that cause the fallback to kexec_file.
>
> Without -p kexec_file_load actualy leads to a kernel oops on v6.4.0
> (needs to be dubugged separately).
>
> Signed-off-by: Jiri Bohac <jbohac@suse.cz>
> Fixes: 29fe5067ed07 ("kexec: make -a the default")
Thanks Jiri,
and sorry for the delay.
Applied to main.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2024-01-25 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 17:14 [PATCH] kexec: don't use kexec_file_load on XEN Jiri Bohac
2024-01-25 17:02 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125170245.GA245752@kernel.org \
--to=horms@kernel.org \
--cc=jbohac@suse.cz \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).