From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Nikolay Borisov <nik.borisov@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Elena Reshetova <elena.reshetova@intel.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Kalra, Ashish" <ashish.kalra@amd.com>,
Sean Christopherson <seanjc@google.com>,
"Huang, Kai" <kai.huang@intel.com>, Baoquan He <bhe@redhat.com>,
kexec@lists.infradead.org, linux-coco@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv5 10/16] x86/tdx: Convert shared memory back to private on kexec
Date: Tue, 16 Jan 2024 13:53:24 +0300 [thread overview]
Message-ID: <20240116105324.5kz6b2b6cbv6g4xn@box.shutemov.name> (raw)
In-Reply-To: <20240116072822.pvzseyqry56eqa4j@box.shutemov.name>
On Tue, Jan 16, 2024 at 10:28:22AM +0300, Kirill A. Shutemov wrote:
> > > @@ -809,12 +823,25 @@ static bool tdx_enc_status_changed(unsigned long vaddr, int numpages, bool enc)
> > > static int tdx_enc_status_change_prepare(unsigned long vaddr, int numpages,
> > > bool enc)
> > > {
> > > + atomic_inc(&conversions_in_progress);
> > > +
> > > + /*
> > > + * Check after bumping conversions_in_progress to serialize
> > > + * against tdx_shutdown().
s/tdx_shutdown/tdx_kexec_stop_conversion/
> > > + */
> > > + if (!conversion_allowed) {
> > > + atomic_dec(&conversions_in_progress);
> > > + return -EBUSY;
> > > + }
> >
> > nit: Can you make the inc of conversions_in_progress be done here, this
> > eliminated the atomic_dec in case they aren't. Somewhat simplifies the
> > logic.
>
> Okay, fair enough. Will change.
Actually, no, it will breaks serialization.
Consider following scenario (includes change you proposed):
CPU0 CPU1
tdx_enc_status_change_prepare()
if (!conversion_allowed) // false
tdx_kexec_stop_conversion()
conversion_allowed = false;
<...>
<return as no conversion in flight>
<continue with conversion>
Incrementing conversion_in_progress before checking conversion_allowed
will make tdx_kexec_stop_conversion() to spin until CPU0 is done with
conversion.
--
Kiryl Shutsemau / Kirill A. Shutemov
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2024-01-16 10:53 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 23:51 [PATCHv5 00/16] x86/tdx: Add kexec support Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 01/16] x86/acpi: Extract ACPI MADT wakeup code into a separate file Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 02/16] x86/apic: Mark acpi_mp_wake_* variables as __ro_after_init Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 03/16] cpu/hotplug: Add support for declaring CPU offlining not supported Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 04/16] cpu/hotplug, x86/acpi: Disable CPU offlining for ACPI MADT wakeup Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 05/16] x86/kvm: Do not try to disable kvmclock if it was not enabled Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 06/16] x86/kexec: Keep CR4.MCE set during kexec for TDX guest Kirill A. Shutemov
2023-12-22 23:51 ` [PATCHv5 07/16] x86/mm: Make x86_platform.guest.enc_status_change_*() return errno Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 08/16] x86/mm: Return correct level from lookup_address() if pte is none Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 09/16] x86/tdx: Account shared memory Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 10/16] x86/tdx: Convert shared memory back to private on kexec Kirill A. Shutemov
2024-01-05 19:38 ` Edgecombe, Rick P
2024-01-06 0:59 ` kirill.shutemov
2024-01-06 1:12 ` Edgecombe, Rick P
2024-01-15 10:53 ` Nikolay Borisov
2024-01-16 7:28 ` Kirill A. Shutemov
2024-01-16 8:01 ` Nikolay Borisov
2024-01-16 10:45 ` Kirill A. Shutemov
2024-01-16 10:53 ` Kirill A. Shutemov [this message]
2023-12-22 23:52 ` [PATCHv5 11/16] x86/mm: Make e820_end_ram_pfn() cover E820_TYPE_ACPI ranges Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 12/16] x86/acpi: Rename fields in acpi_madt_multiproc_wakeup structure Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 13/16] x86/acpi: Do not attempt to bring up secondary CPUs in kexec case Kirill A. Shutemov
2023-12-22 23:52 ` [PATCHv5 14/16] x86/smp: Add smp_ops.stop_this_cpu() callback Kirill A. Shutemov
2023-12-25 8:05 ` [PATCHv5.1 " Kirill A. Shutemov
2024-01-08 3:04 ` Huang, Kai
2024-01-08 10:15 ` kirill.shutemov
2024-01-09 3:04 ` Huang, Kai
2023-12-22 23:52 ` [PATCHv5 15/16] x86/mm: Introduce kernel_ident_mapping_free() Kirill A. Shutemov
2024-01-08 3:13 ` Huang, Kai
2024-01-08 3:30 ` Huang, Kai
2024-01-08 10:17 ` kirill.shutemov
2024-01-08 13:13 ` Huang, Kai
2024-01-08 13:35 ` kirill.shutemov
2023-12-22 23:52 ` [PATCHv5 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method Kirill A. Shutemov
2024-01-15 13:19 ` Nikolay Borisov
2024-01-16 6:50 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116105324.5kz6b2b6cbv6g4xn@box.shutemov.name \
--to=kirill.shutemov@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=ashish.kalra@amd.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=elena.reshetova@intel.com \
--cc=jun.nakajima@intel.com \
--cc=kai.huang@intel.com \
--cc=kexec@lists.infradead.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).