kexec.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: fuqiang wang <fuqiang.wang@easystack.cn>
To: Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
	Dave Young <dyoung@redhat.com>, Yuntao Wang <ytcoode@gmail.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] kexec: fix potential cmem->ranges out of bounds
Date: Wed, 20 Dec 2023 13:57:30 +0800	[thread overview]
Message-ID: <20231220055733.100325-1-fuqiang.wang@easystack.cn> (raw)

This series tries to fix the potential cmem->ranges out of bounds.

On the v1 version, there are still some issues that need to be
discussed, as follows:

1) Whether we need have the cmem->ranges[] partly changed, or keep it
unchanged when OOB happened. Previously discussed link:[1].

2) Set cmem->max_nr_ranges in crash_setup_memmap_entries() to 1 or 2.
Previously discussed link:[2].

3) To enhance crash_setup_memmap_entries() readability, how to move
code. Previously discussed link:[2].

v2:
  - Fix potential out of bounds in crash_setup_memmap_entries().
  - Add a comment in fill_up_crash_elf_data() to explain why the array
    size do not need to be changed.

v1:
  Link: https://lore.kernel.org/all/20231127025641.62210-1-fuqiang.wang@easystack.cn/

[1]: https://lore.kernel.org/all/ZXrY7QbXAlxydsSC@MiWiFi-R3L-srv/
[2]: https://lore.kernel.org/all/273284e8-7680-4f5f-8065-c5d780987e59@easystack.cn/

fuqiang wang (2):
  x86/kexec: Fix potential out of bounds in crash_setup_memmap_entries()
  kexec: Fix potential out of bounds in crash_exclude_mem_range()

 arch/x86/kernel/crash.c | 20 ++++++++++++++------
 kernel/crash_core.c     |  7 +++----
 2 files changed, 17 insertions(+), 10 deletions(-)

-- 
2.42.0


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

             reply	other threads:[~2023-12-20  5:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20  5:57 fuqiang wang [this message]
2023-12-20  5:57 ` [PATCH v2 1/2] x86/kexec: Fix potential out of bounds in crash_setup_memmap_entries() fuqiang wang
2023-12-21 13:14   ` Baoquan He
2023-12-22 11:41     ` fuqiang wang
2023-12-20  5:57 ` [PATCH v2 2/2] kexec: Fix potential out of bounds in crash_exclude_mem_range() fuqiang wang
2023-12-21 11:42   ` Baoquan He
2023-12-22 11:08     ` fuqiang wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231220055733.100325-1-fuqiang.wang@easystack.cn \
    --to=fuqiang.wang@easystack.cn \
    --cc=bhe@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    --cc=ytcoode@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).