From: Simon Horman <horms@kernel.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: kexec@lists.infradead.org, Jason@zx2c4.com
Subject: Re: [PATCH] m68k: fix getrandom() use with uclibc
Date: Mon, 27 Nov 2023 13:46:30 +0000 [thread overview]
Message-ID: <20231127134630.GB3354982@kernel.org> (raw)
In-Reply-To: <20230422095904.1303434-1-laurent@vivier.eu>
On Sat, Apr 22, 2023 at 11:59:04AM +0200, Laurent Vivier wrote:
> With uclibc, getrandom() is only defined with _GNU_SOURCE, fix that:
>
> kexec/arch/m68k/bootinfo.c: In function 'bootinfo_add_rng_seed':
> kexec/arch/m68k/bootinfo.c:231:13: warning: implicit declaration of function 'getrandom'; did you mean 'srandom'? [-Wimplicit-function-declaration]
> 231 | if (getrandom(bi->rng_seed.data, RNG_SEED_LEN, GRND_NONBLOCK) != RNG_SEED_LEN) {
> | ^~~~~~~~~
> | srandom
> kexec/arch/m68k/bootinfo.c:231:56: error: 'GRND_NONBLOCK' undeclared (first use in this function)
> 231 | if (getrandom(bi->rng_seed.data, RNG_SEED_LEN, GRND_NONBLOCK) != RNG_SEED_LEN) {
> | ^~~~~~~~~~~~~
>
> Fixes: b9de05184816 ("m68k: pass rng seed via BI_RNG_SEED")
> Cc: Jason@zx2c4.com
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2023-11-27 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 9:59 [PATCH] m68k: fix getrandom() use with uclibc Laurent Vivier
2023-11-27 13:46 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127134630.GB3354982@kernel.org \
--to=horms@kernel.org \
--cc=Jason@zx2c4.com \
--cc=kexec@lists.infradead.org \
--cc=laurent@vivier.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).