From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Ayush Singh <ayushdevel1325@gmail.com>, kernelnewbies@kernelnewbies.org
Subject: Re: Adding compatible string to standard UART
Date: Thu, 14 Sep 2023 09:10:15 +0200 [thread overview]
Message-ID: <9af74b78-cce3-b822-5145-54bef71842c5@pengutronix.de> (raw)
In-Reply-To: <1e8badf8-dfea-bd37-ab1d-c8d8f9de6f9b@gmail.com>
Hello Ayush,
On 29.08.23 18:58, Ayush Singh wrote:
> Hello everyone. I have been working on submitting my GSoC23 driver [1] to be merged upstream.
>
> BeaglePlay has a specific UART that is connected to the CC1352 Co-processor. This UART is used to communicate with CC1352 co-processor. It is also used to flash stuff to this co-processor using bsl. Thus, it should be possible to disable it with an overlay and show it as a normal ttyS* device. Currently, the beagle kernel uses the following dts [3].
>
> My driver uses this UART and thus I need to patch the devicetree. However, I am not too sure what I need to do to submit my device tree patch upstream. I read the Submitting Devicetree (DT) binding patches' doc [2], but I don't understand a few things:
>
>
> 1. Should I even be using device tree? Maybe there is a better method?
I haven't checked your links, but from your description, serdev might be what
you're after. In the DT that would be a child node of the existing serial
device.
> 2. Is there some naming convention? I was thinking of `beagle,cc1352-uart`
Not sure about the uart suffix. beagle,play-cc1352 sounds fine for a v1, I think.
>
> 3. Do I need a documentation entry at `Documentation/devicetree/bindings`? If yes, should it go under serial?
Only if the cc1352 is itself a UART adapter, which doesn't appear to be the case.
Look what the function of the device has and choose the appropriate directory.
For coprocessors that have multiple functions, the main node is described
in mfd/ and the different functions in their respective directories.
>
> 4. I think I am supposed to use YAML now and not txt?
Yes.
>
> 5. What are the required fields in this doc file?
Just take a similar device as a template. See what's already in mfd/
and see what's similar to your usage.
Cheers,
Ahmad
>
>
> Ayush Singh
>
>
>
> [1]: https://github.com/Ayush1325/linux/tree/gb-beagleplay
>
> [2]: https://docs.kernel.org/devicetree/bindings/submitting-patches.html
>
> [3]: https://git.beagleboard.org/beagleboard/linux/-/blob/v5.10.168-ti-arm64-r103/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts#L1206
>
>
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
prev parent reply other threads:[~2023-09-14 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 16:58 Adding compatible string to standard UART Ayush Singh
2023-09-14 7:10 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9af74b78-cce3-b822-5145-54bef71842c5@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=ayushdevel1325@gmail.com \
--cc=kernelnewbies@kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).