From: Anton Gusev <aagusev@ispras.ru>
To: kernelnewbies@kernelnewbies.org
Subject: Need help determining if the change is warranted.
Date: Mon, 27 Mar 2023 14:34:33 +0300 [thread overview]
Message-ID: <6d8ba15e-254e-7b31-b3b8-cda9e6a2759b@ispras.ru> (raw)
In the file drivers/leds/flash/leds-lm3601x.c, function
lm3601x_strobe_set, the calls to regmap_update_bits aren't checked for
errors.
I am unsure whether adding the checks is warranted, since
lm3601x_read_faults might cover the conditions that can cause
regmap_update_bits to fail there. On the other hand, if this is not
true, then lm3601x_strobe_set can fail silently. Also, all other calls
to regmap_update_bit in the driver are checked or directly returned.
--
Anton Gusev
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next reply other threads:[~2023-03-27 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 11:34 Anton Gusev [this message]
2023-05-27 0:36 ` Need help determining if the change is warranted Alison Schofield
2023-05-27 6:05 ` Lucas Tanure
2023-05-28 4:18 ` Valdis Klētnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d8ba15e-254e-7b31-b3b8-cda9e6a2759b@ispras.ru \
--to=aagusev@ispras.ru \
--cc=kernelnewbies@kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).