From: Alan Jenkins <sourcejedi.lkml-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
To: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>
Cc: Mel Gorman <mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>,
hugh.dickins-IWqWACnzNjwqdlJmJB21zg@public.gmane.org,
Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>,
pm list
<linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Kernel Testers List
<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Linux MM <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>
Subject: Re: s2disk hang update
Date: Fri, 26 Feb 2010 09:26:37 +0000 [thread overview]
Message-ID: <9b2b86521002260126g5acabb79uae961dd8668b3c09@mail.gmail.com> (raw)
In-Reply-To: <201002252104.51187.rjw-KKrjLPT3xs0@public.gmane.org>
On 2/25/10, Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> On Thursday 25 February 2010, Alan Jenkins wrote:
>> On 2/24/10, Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
>> > On Wednesday 24 February 2010, Alan Jenkins wrote:
> ...
>>
>> > - while (to_free_normal > 0 && to_free_highmem > 0) {
>> > + while (to_free_normal > 0 || to_free_highmem > 0) {
>>
>> Yes, that seems to do it. No more hangs so far (and I can still
>> reproduce the hang with too many applications if I un-apply the
>> patch).
>
> OK, great. Is this with or without the NOIO-enforcing patch?
With.
>> I did see a non-fatal allocation failure though, so I'm still not sure
>> that the current implementation is strictly correct.
>>
>> This is without the patch to increase "to_free_normal". If I get the
>> allocation failure again, should I try testing the "free 20% extra"
>> patch?
>
> Either that or try to increase SPARE_PAGES. That should actually work with
> the last patch applied. :-)
>
> Rafael
<grin>, OK.
prev parent reply other threads:[~2010-02-26 9:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 15:03 s2disk hang update Alan Jenkins
[not found] ` <9b2b86521001020703v23152d0cy3ba2c08df88c0a79-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-02 20:38 ` Rafael J. Wysocki
2010-02-02 14:21 ` Alan Jenkins
2010-02-02 20:34 ` Rafael J. Wysocki
2010-02-03 11:14 ` Alan Jenkins
[not found] ` <9b2b86521002030314s6f84b482v8cd680be556f8a4d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-09 16:36 ` Alan Jenkins
[not found] ` <4B718F11.2010402-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2010-02-15 23:08 ` Rafael J. Wysocki
[not found] ` <201002160008.51875.rjw-KKrjLPT3xs0@public.gmane.org>
2010-02-16 11:09 ` Alan Jenkins
[not found] ` <9b2b86521002160309g26d60bd2t4c19bd2294b76c28-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-16 15:12 ` Alan Jenkins
[not found] ` <9b2b86521002160712r39ecb2b1q5e01389e9209e17b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-16 21:16 ` Rafael J. Wysocki
[not found] ` <201002162216.30192.rjw-KKrjLPT3xs0@public.gmane.org>
2010-02-17 11:27 ` Alan Jenkins
[not found] ` <9b2b86521002170327m1f08ff73ncca9e5eff77b1966-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 19:58 ` Rafael J. Wysocki
[not found] ` <201002172058.04043.rjw-KKrjLPT3xs0@public.gmane.org>
2010-02-18 12:53 ` Alan Jenkins
[not found] ` <9b2b86521002180453l176a83dand809dc239c220c08-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-18 20:04 ` Rafael J. Wysocki
[not found] ` <201002182104.49631.rjw-KKrjLPT3xs0@public.gmane.org>
2010-02-19 11:48 ` Alan Jenkins
[not found] ` <201002212147.07987.rjw@sisk.pl>
[not found] ` <201002212147.07987.rjw-KKrjLPT3xs0@public.gmane.org>
2010-02-22 15:35 ` Alan Jenkins
[not found] ` <4B82A440.6010701-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2010-02-22 19:17 ` Rafael J. Wysocki
[not found] ` <201002222017.55588.rjw-KKrjLPT3xs0@public.gmane.org>
2010-02-23 14:24 ` Alan Jenkins
[not found] ` <9b2b86521002230624g20661564mc35093ee0423ff77-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-23 21:13 ` Rafael J. Wysocki
[not found] ` <201002232213.56455.rjw-KKrjLPT3xs0@public.gmane.org>
2010-02-24 1:20 ` KAMEZAWA Hiroyuki
[not found] ` <20100224102037.2cca4f83.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2010-02-24 20:19 ` Alan Jenkins
2010-02-24 20:36 ` Rafael J. Wysocki
2010-02-24 16:23 ` Alan Jenkins
[not found] ` <9b2b86521002240823t126d5ad8nbd292da0f4090e6c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-24 20:52 ` Rafael J. Wysocki
[not found] ` <201002242152.55408.rjw-KKrjLPT3xs0@public.gmane.org>
2010-02-25 13:10 ` Alan Jenkins
[not found] ` <9b2b86521002250510m75c8b314o37388a04b53a2b67-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-25 20:04 ` Rafael J. Wysocki
[not found] ` <201002252104.51187.rjw-KKrjLPT3xs0@public.gmane.org>
2010-02-26 9:26 ` Alan Jenkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b2b86521002260126g5acabb79uae961dd8668b3c09@mail.gmail.com \
--to=sourcejedi.lkml-gm/ye1e23mwn+bqq9rbeug@public.gmane.org \
--cc=hugh.dickins-IWqWACnzNjwqdlJmJB21zg@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).