From: Jens Axboe <jaxboe-5c4llco8/ftWk0Htik3J/w@public.gmane.org>
To: Markus Trippelsdorf <markus-xp2qqqlHh3xzoYq+O6RWwA@public.gmane.org>
Cc: Tejun Heo <htejun-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Maciej Rutecki
<maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Kernel Testers List
<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Network Development
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux ACPI <linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux PM List
<linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
Linux SCSI List
<linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Wireless List
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
DRI <dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH RESEND block#for-2.6.36] block_dev: always serialize exclusive open attempts
Date: Thu, 5 Aug 2010 11:20:51 +0200 [thread overview]
Message-ID: <4C5A8273.2010803@fusionio.com> (raw)
In-Reply-To: <20100805091704.GA1772-joY5NpejW+Hx3b7vapvTcQ@public.gmane.org>
On 2010-08-05 11:17, Markus Trippelsdorf wrote:
> On Thu, Aug 05, 2010 at 11:02:43AM +0200, Jens Axboe wrote:
>> On 2010-08-04 17:59, Tejun Heo wrote:
>>> bd_prepare_to_claim() incorrectly allowed multiple attempts for
>>> exclusive open to progress in parallel if the attempting holders are
>>> identical. This triggered BUG_ON() as reported in the following bug.
>>>
>>> https://bugzilla.kernel.org/show_bug.cgi?id=16393
>>>
>>> __bd_abort_claiming() is used to finish claiming blocks and doesn't
>>> work if multiple openers are inside a claiming block. Allowing
>>> multiple parallel open attempts to continue doesn't gain anything as
>>> those are serialized down in the call chain anyway. Fix it by always
>>> allowing only single open attempt in a claiming block.
>>>
>>> This problem can easily be reproduced by adding a delay after
>>> bd_prepare_to_claim() and attempting to mount two partitions of a
>>> disk.
>>>
>>> stable: only applicable to v2.6.35
>>>
>>> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>> Reported-by: Markus Trippelsdorf <markus-xp2qqqlHh3xzoYq+O6RWwA@public.gmane.org>
>>> Cc: stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
>>
>> Thanks Tejun, applied.
>
> It's already in mainline:
> e75aa85892b2ee78c79edac720868cbef16e62eb
Irk, had not noticed yet, my for-2.6.36 branch isn't fully merged
up yet. Thanks for the heads-up.
--
Jens Axboe
Confidentiality Notice: This e-mail message, its contents and any attachments to it are confidential to the intended recipient, and may contain information that is privileged and/or exempt from disclosure under applicable law. If you are not the intended recipient, please immediately notify the sender and destroy the original e-mail message and any attachments (and any copies that may have been made) from your system or otherwise. Any unauthorized use, copying, disclosure or distribution of this information is strictly prohibited.
next prev parent reply other threads:[~2010-08-05 9:20 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-01 13:46 2.6.35-rc6-git6: Reported regressions from 2.6.34 Rafael J. Wysocki
2010-08-01 13:46 ` [Bug #16173] After uncompressing the kernel, at boot time, the server hangs Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16307] i915 in kernel 2.6.35-rc3, high number of wakeups Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16278] lvm snapshot causes deadlock in 2.6.35 Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16265] Why is kslowd accumulating so much CPU time? Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16228] BUG/boot failure on Dell Precision T3500 (pci/ahci_stop_engine) Rafael J. Wysocki
2010-08-02 0:27 ` Bjorn Helgaas
2010-08-01 13:52 ` [Bug #16184] Container, X86-64, i386, iptables rule Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16221] 2.6.35-rc2-git5 -- [drm:drm_mode_getfb] *ERROR* invalid framebuffer id Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16215] sysfs: cannot create duplicate filename '/class/net/bnep0' Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16312] WARNING: at fs/fs-writeback.c:1127 __mark_inode_dirty Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16310] arm omap invalid module format Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16322] WARNING: at /arch/x86/include/asm/processor.h:1005 read_measured_perf_ctrs+0x5a/0x70() Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16337] general protection fault: 0000 [#1] SMP Rafael J. Wysocki
2010-08-02 1:01 ` Justin P. Mattock
[not found] ` <4C5618DA.1020407-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-08-02 13:34 ` Rafael J. Wysocki
2010-08-02 13:47 ` Justin P. Mattock
2010-08-01 13:52 ` [Bug #16369] Yet another 2.6.35 regression (AGP)? Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16383] Regression with e1000e from 2.6.34.1 to 2.6.35-rc5 Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16365] kernel BUG at fs/btrfs/extent-tree.c:1353 Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16380] Loop devices act strangely in 2.6.35 Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16399] perf failed with kernel 2.6.35-rc Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16393] kernel BUG at fs/block_dev.c:765! Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16396] [bisected] resume from suspend freezes system Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16400] 2.6.35-rc5 inconsistent lock state Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16406] Badness with the kernel version 2.6.35-rc1-git1 running on P6 box Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16423] netfilter/iptables stopped logging 2.6.35-rc Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16405] Brightness Adjustment on Toshiba nb305 Netbooks is non-functional Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16448] 2.6.35-rc5 panic at __br_deliver+0x64/0xe0 with kvm bridge networking Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16458] Bluetooth disabled after resume Rafael J. Wysocki
2010-08-02 12:19 ` Oliver Neukum
2010-08-01 13:52 ` [Bug #16450] MTD drivers cannot be unloaded Rafael J. Wysocki
2010-08-01 13:52 ` [Bug #16462] unable to connect to AP on legal channels 12/13 Rafael J. Wysocki
2010-08-02 14:58 ` Daniel J Blueman
[not found] ` <AANLkTikmgrKTLtgs1+h+BkS5X6qt9bP1wMDL4Gu7L3u3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-02 15:49 ` Justin P. Mattock
2010-08-02 15:51 ` Justin P. Mattock
2010-08-01 14:48 ` 2.6.35-rc6-git6: Reported regressions from 2.6.34 Stefan Richter
2010-08-01 15:50 ` Rafael J. Wysocki
2010-08-01 18:01 ` Linus Torvalds
[not found] ` <AANLkTimcH7+Bq1UEbaSU7SQpzArPgmSLegiqE13V8=CF-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-01 21:37 ` Rafael J. Wysocki
2010-08-02 16:32 ` Tejun Heo
2010-08-04 15:40 ` [PATCH block#for-2.6.36] block_dev: always serialize exclusive open attempts Tejun Heo
2010-08-04 15:59 ` [PATCH RESEND " Tejun Heo
2010-08-05 9:02 ` Jens Axboe
[not found] ` <4C5A7E33.3060101-5c4llco8/ftWk0Htik3J/w@public.gmane.org>
2010-08-05 9:17 ` Markus Trippelsdorf
[not found] ` <20100805091704.GA1772-joY5NpejW+Hx3b7vapvTcQ@public.gmane.org>
2010-08-05 9:20 ` Jens Axboe [this message]
2010-08-01 19:39 ` 2.6.35-rc6-git6: Reported regressions from 2.6.34 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5A8273.2010803@fusionio.com \
--to=jaxboe-5c4llco8/ftwk0htik3j/w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=htejun-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=markus-xp2qqqlHh3xzoYq+O6RWwA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).