From: "Américo Wang" <xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>
Cc: Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Kernel Testers List
<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Maciej Rutecki
<maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Nikola Ciprich
<extmaillist-Jp3n8lUXroTtwjQa/ONI9g@public.gmane.org>
Subject: Re: [Bug #14943] nfs regression?
Date: Mon, 22 Feb 2010 10:13:18 +0800 [thread overview]
Message-ID: <2375c9f91002211813m8f637c1g73c4314eab96f81e@mail.gmail.com> (raw)
In-Reply-To: <wj3ZQZlk_KB.A.M6B.QsagLB@chimera>
On Mon, Feb 22, 2010 at 5:42 AM, Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> This message has been generated automatically as a part of a report
> of regressions introduced between 2.6.31 and 2.6.32.
>
> The following bug entry is on the current list of known regressions
> introduced between 2.6.31 and 2.6.32. Please verify if it still should
> be listed and let the tracking team know (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14943
> Subject : nfs regression?
> Submitter : Nikola Ciprich <extmaillist@linuxbox.cz>
> Date : 2009-12-28 12:10 (56 days old)
> References : http://marc.info/?l=linux-kernel&m=126200276223524&w=4
>
This seems that we missed checking XPT_DEAD too.
Nikola, does adding !test_bit(XPT_DEAD, &xprt->xpt_flags) in the same
place as commit b292cf9ce70d221c3f04f help?
Something like:
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index 7d1f9e9..7b66c7f 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -700,7 +700,8 @@ int svc_recv(struct svc_rqst *rqstp, long timeout)
len = 0;
if (test_bit(XPT_LISTENER, &xprt->xpt_flags) &&
- !test_bit(XPT_CLOSE, &xprt->xpt_flags)) {
+ !test_bit(XPT_CLOSE, &xprt->xpt_flags) &&
+ !test_bit(XPT_DEAD, &xprt->xpt_flags)) {
struct svc_xprt *newxpt;
newxpt = xprt->xpt_ops->xpo_accept(xprt);
if (newxpt) {
next parent reply other threads:[~2010-02-22 2:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4u4d-2M3yXH.A.XW.XqagLB@chimera>
[not found] ` <wj3ZQZlk_KB.A.M6B.QsagLB@chimera>
2010-02-22 2:13 ` Américo Wang [this message]
[not found] ` <2375c9f91002211813m8f637c1g73c4314eab96f81e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-08 20:21 ` [Bug #14943] nfs regression? Nikola Ciprich
[not found] ` <wj3ZQZlk_KB.A.Ye.iqagLB@chimera>
2010-02-22 2:18 ` [Bug #15309] reiserfs issue with 2.6.32.8 Bret Towe
[not found] ` <wj3ZQZlk_KB.A.Q0C.hwagLB@chimera>
2010-02-24 7:58 ` [Bug #14656] Oops at __rmqueue+0x98 with 2.6.32-rc6 Christian Kujau
2010-02-14 23:46 2.6.33-rc8: Reported regressions 2.6.31 -> 2.6.32 Rafael J. Wysocki
2010-02-14 23:52 ` [Bug #14943] nfs regression? Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2010-02-01 0:38 2.6.33-rc6: Reported regressions 2.6.31 -> 2.6.32 Rafael J. Wysocki
2010-02-01 0:43 ` [Bug #14943] nfs regression? Rafael J. Wysocki
2010-02-01 21:46 ` Nikola Ciprich
2010-01-24 22:15 2.6.33-rc5: Reported regressions 2.6.31 -> 2.6.32 Rafael J. Wysocki
2010-01-24 22:23 ` [Bug #14943] nfs regression? Rafael J. Wysocki
2010-01-10 22:45 2.6.33-rc3-git3: Reported regressions 2.6.31 -> 2.6.32 Rafael J. Wysocki
2010-01-10 22:56 ` [Bug #14943] nfs regression? Rafael J. Wysocki
2009-12-29 15:26 2.6.33-rc2: Reported regressions 2.6.31 -> 2.6.32 Rafael J. Wysocki
2009-12-29 15:28 ` [Bug #14943] nfs regression? Rafael J. Wysocki
2009-12-29 18:33 ` Nikola Ciprich
[not found] ` <20091229183357.GA4476-YtsXe8XL0VS8z6Q06MQEFCF40CQGThNF@public.gmane.org>
2009-12-29 21:47 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2375c9f91002211813m8f637c1g73c4314eab96f81e@mail.gmail.com \
--to=xiyou.wangcong-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=extmaillist-Jp3n8lUXroTtwjQa/ONI9g@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).