From: Lee Jones <lee.jones@linaro.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Markus Pargmann <mpa@pengutronix.de>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc: imx25-gcq: fix do_div
Date: Wed, 16 Mar 2016 08:39:50 +0000 [thread overview]
Message-ID: <20160316083950.GU13692@x1> (raw)
In-Reply-To: <56E3F8D3.3020707@kernel.org>
On Sat, 12 Mar 2016, Jonathan Cameron wrote:
> On 07/03/16 11:06, Sudip Mukherjee wrote:
> > On Mon, Mar 07, 2016 at 10:01:34AM +0100, Markus Pargmann wrote:
> >> Hi,
> >>
> >> On Saturday 05 March 2016 18:43:11 Jonathan Cameron wrote:
> >>> On 03/03/16 12:51, Sudip Mukherjee wrote:
> >>>> We are getting build failure with tilepro allmodconfig with the error:
> >>>>
> >>>> drivers/iio/adc/fsl-imx25-gcq.c:236:4: note: in expansion of macro 'do_div'
> >>>> do_div(priv->channel_vref_mv[reg], 1000);
> >>>> ^
> >>>>
> >>>> include/asm-generic/div64.h:198:17: note: expected 'uint64_t *
> >>>> {aka long long unsigned int *}' but argument is of type 'u32 *
> >>>> {aka unsigned int *}'
> >>>>
> >>>> Create a temporary variable of type u64 and use that in do_div.
> >>>>
> >>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> >>> Markus, can you take a quick look at this.
> >>
> >> Thanks. I think this was already fixed by Arnd.
> >> "iio: adc/imx25-gcq: move incorrect do_div"
> >
> > It should. But I still have the same build failure with next-20160307
> > and not only tilepro, even m32r is also having the same build failure.
> >
> Lee, did you pick the original fix from Arnd up?
>
> I can take this after the merge window if not.
Yes, it's in my tree.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-03-16 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 12:51 [PATCH] iio: adc: imx25-gcq: fix do_div Sudip Mukherjee
[not found] ` <1457009513-7069-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-05 18:43 ` Jonathan Cameron
[not found] ` <56DB28BF.9070508-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-03-07 9:01 ` Markus Pargmann
2016-03-07 11:06 ` Sudip Mukherjee
2016-03-12 11:09 ` Jonathan Cameron
2016-03-16 8:39 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316083950.GU13692@x1 \
--to=lee.jones@linaro.org \
--cc=jic23@kernel.org \
--cc=kernel-testers@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=pmeerw@pmeerw.net \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).