kernel-testers.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: FUJITA Tomonori <fujita.tomonori-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
To: rjw-KKrjLPT3xs0@public.gmane.org,
	mchehab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	zdenek.kabelac-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org
Subject: Re: [Bug #15977] WARNING: at lib/dma-debug.c:866 check_for_stack
Date: Fri, 30 Jul 2010 15:58:04 +0900	[thread overview]
Message-ID: <20100730155605S.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <PRbv8sgxY6G.A.ksG.eWYSMB@chimera>

On Fri, 23 Jul 2010 14:15:49 +0200 (CEST)
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org> wrote:

> This message has been generated automatically as a part of a report
> of regressions introduced between 2.6.33 and 2.6.34.
> 
> The following bug entry is on the current list of known regressions
> introduced between 2.6.33 and 2.6.34.  Please verify if it still should
> be listed and let the tracking team know (either way).
> 
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=15977
> Subject		: WARNING: at lib/dma-debug.c:866 check_for_stack
> Submitter	: Zdenek Kabelac <zdenek.kabelac-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date		: 2010-05-14 8:56 (71 days old)
> Message-ID	: <AANLkTikyx2eaxaiUCFDSfpmn1UG0t2GOxArz6F4wp1LJ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> References	: http://marc.info/?l=linux-kernel&m=127382742729825&w=2

looks like easy to fix this. But seems that linux-next still has the
bug. Or a fix was already posted somewhere else?

=
From: FUJITA Tomonori <fujita.tomonori-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
Subject: [PATCH] DVB: dib0700: fix the usage of stack buffers for DMA

We can't use a stack buffer for DMA.

This should fix:

http://bugzilla.kernel.org/show_bug.cgi?id=15977

Signed-off-by: FUJITA Tomonori <fujita.tomonori-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
---
 drivers/media/dvb/dvb-usb/dib0700_core.c |   15 ++++++++++++---
 1 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/drivers/media/dvb/dvb-usb/dib0700_core.c b/drivers/media/dvb/dvb-usb/dib0700_core.c
index 7deade7..54a0d2c 100644
--- a/drivers/media/dvb/dvb-usb/dib0700_core.c
+++ b/drivers/media/dvb/dvb-usb/dib0700_core.c
@@ -301,14 +301,23 @@ struct i2c_algorithm dib0700_i2c_algo = {
 int dib0700_identify_state(struct usb_device *udev, struct dvb_usb_device_properties *props,
 			struct dvb_usb_device_description **desc, int *cold)
 {
-	u8 b[16];
-	s16 ret = usb_control_msg(udev, usb_rcvctrlpipe(udev,0),
-		REQUEST_GET_VERSION, USB_TYPE_VENDOR | USB_DIR_IN, 0, 0, b, 16, USB_CTRL_GET_TIMEOUT);
+	void *b;
+	s16 ret;
+
+	b = kmalloc(16, GFP_KERNEL);
+	if (!b)
+		return -ENOMEM;
+
+	ret = usb_control_msg(udev, usb_rcvctrlpipe(udev,0),
+			      REQUEST_GET_VERSION, USB_TYPE_VENDOR | USB_DIR_IN,
+			      0, 0, b, 16, USB_CTRL_GET_TIMEOUT);
 
 	deb_info("FW GET_VERSION length: %d\n",ret);
 
 	*cold = ret <= 0;
 
+	kfree(b);
+
 	deb_info("cold: %d\n", *cold);
 	return 0;
 }
-- 
1.6.5

  reply	other threads:[~2010-07-30  6:58 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-23 12:11 2.6.35-rc6: Reported regressions 2.6.33 -> 2.6.34 Rafael J. Wysocki
2010-07-23 12:11 ` [Bug #15664] Graphics hang and kernel backtrace when starting Azureus with Compiz enabled Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #15673] 2.6.34-rc2: "ima_dec_counts: open/free imbalance"? Rafael J. Wysocki
2010-07-23 15:12   ` Thomas Meyer
     [not found]     ` <1279897933.3126.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-07-23 19:50       ` Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #15977] WARNING: at lib/dma-debug.c:866 check_for_stack Rafael J. Wysocki
2010-07-30  6:58   ` FUJITA Tomonori [this message]
2010-07-23 12:15 ` [Bug #15912] Audio/video sync and crackling issues with snd-hda-intel (AD1981 codec) Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #15704] [r8169] WARNING: at net/sched/sch_generic.c Rafael J. Wysocki
2010-07-26 13:16   ` Sergey Senozhatsky
2010-07-26 14:34     ` Eric Dumazet
2010-07-26 14:57       ` Sergey Senozhatsky
     [not found]         ` <20100726145742.GA4888-dY8u8AhHFaWtd10JCjopabkcH5ONE+aC@public.gmane.org>
2010-07-26 15:20           ` Eric Dumazet
2010-07-26 15:50   ` Sergey Senozhatsky
2010-07-23 12:15 ` [Bug #15862] 2.6.34-rc4/5: iwlagn unusable until reload Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16035] Incorrect initial resolution of (external) vga monitor with KMS Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16097] 2.6.34 on Samsung P460: reset after "Waiting for /dev to be fully populated" Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16007] x86/pci Oops with CONFIG_SND_HDA_INTEL Rafael J. Wysocki
2010-07-23 14:20   ` Bjorn Helgaas
2010-07-23 19:51     ` Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16082] host panic on kernel 2.6.34 Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16139] wait_even_interruptible_timeout(), signal, spin_lock() = system hang Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16111] hostap_pci: infinite registered netdevice wifi0 Rafael J. Wysocki
2010-07-23 13:13   ` Tim Gardner
     [not found]     ` <4C49958E.6060808-FkRxxPpxr6pWk0Htik3J/w@public.gmane.org>
2010-07-23 19:53       ` Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16206] PROBLEM: PPP and other serial port related application hangs in kernel space Rafael J. Wysocki
2010-07-25 19:36   ` Chuck Ebbert
2010-07-23 12:15 ` [Bug #16170] Leadtek Winfast DTV Dongle (STK7700P based) is not working in 2.6.34 Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16137] Ooops in BTRFS in 2.6.34 / x86_64 when mounting subvolume by name Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16207] Suspend and VT switch hangs since 2.6.34 Rafael J. Wysocki
2010-07-23 17:33   ` Jesse Barnes
     [not found]     ` <20100723103336.539a3d61-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
2010-07-23 17:50       ` Tino Keitel
     [not found]         ` <20100723175056.GA30411-dW8JlKMZij8@public.gmane.org>
2010-07-23 17:57           ` Jesse Barnes
2010-07-23 12:15 ` [Bug #16233] Fwd: [2.6.34] INFO: task rsync:20019 blocked for more than 120 seconds Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16320] iwl3945 crashes, seems to be disconnecting from the PCI bus Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16300] [2.6.34 regression] mplayer gets out of sync due to problems with ALSA Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16270] Image is a hit-or-a-miss. Often displayed green+purple Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16371] Regression 2.6.33->2.6.34: OOPS at boot, kmalloc corruption? Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16348] kswapd continuously active when doing IO Rafael J. Wysocki
2010-07-23 13:45   ` Dave Chinner
2010-07-23 19:55     ` Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16357] acpi-cpufreq fails to load (No such device) if CONFIG_SMP=n Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16361] KMS not working on Radeon Mobility 3430 Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16388] i915 drm BUG: unable to handle kernel paging request at a5e89046 Rafael J. Wysocki
2010-07-23 17:37   ` Jesse Barnes
2010-07-23 12:15 ` [Bug #16377] X.org crash while running a OpenGL composited KDE 4.4.4 session with Radeon KMS Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16376] random - possibly Radeon DRM KMS related - freezes Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2010-08-01 14:27 2.6.35-rc6-git6: Reported regressions 2.6.33 -> 2.6.34 Rafael J. Wysocki
2010-08-01 14:44 ` [Bug #15977] WARNING: at lib/dma-debug.c:866 check_for_stack Rafael J. Wysocki
2010-07-10  0:24 2.6.35-rc4-git4: Reported regressions 2.6.33 -> 2.6.34 Rafael J. Wysocki
2010-07-10  0:33 ` [Bug #15977] WARNING: at lib/dma-debug.c:866 check_for_stack Rafael J. Wysocki
2010-06-20 22:32 2.6.35-rc3: Reported regressions 2.6.33 -> 2.6.34 Rafael J. Wysocki
2010-06-20 22:34 ` [Bug #15977] WARNING: at lib/dma-debug.c:866 check_for_stack Rafael J. Wysocki
2010-06-13 14:45 2.6.35-rc3: Reported regressions 2.6.33 -> 2.6.34 Rafael J. Wysocki
2010-06-13 14:49 ` [Bug #15977] WARNING: at lib/dma-debug.c:866 check_for_stack Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100730155605S.fujita.tomonori@lab.ntt.co.jp \
    --to=fujita.tomonori-zyj7fxus5i5l9jvzuh4aog@public.gmane.org \
    --cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
    --cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=mchehab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=rjw-KKrjLPT3xs0@public.gmane.org \
    --cc=zdenek.kabelac-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).