From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dan Scally <dan.scally@ideasonboard.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] media: ipu-bridge: fix error code in ipu_bridge_init()
Date: Tue, 14 May 2024 16:06:39 +0200 [thread overview]
Message-ID: <f2d48c85-9cfe-41af-ac43-d61bb1be4dc3@suswa.mountain> (raw)
In-Reply-To: <3ba30852-cb50-497e-8968-a29d0b9a1986@ideasonboard.com>
On Tue, May 14, 2024 at 11:14:18AM +0100, Dan Scally wrote:
> Hello
>
> On 10/05/2024 16:55, Andy Shevchenko wrote:
> > On Fri, May 10, 2024 at 06:43:31PM +0300, Dan Carpenter wrote:
> > > Return -EINVAL if "bridge->n_sensors == 0". Don't return success.
> > LGTM, but I leave the main Q "Is it really the error case?" to the maintainers.
> > I would imagine the use case where either from the following may happen:
> > 1) the sensors are all new and not listed as supported;
> > 2) there no sensors connected for real.
> >
> > In both cases I don't see this as a critical error that we can't enumerate
> > the bridge itself.
> >
> I have no strong feelings on this really. The CIO2 driver, before the bridge
> was a thing, didn't treat a lack of connected endpoints as an error case and
> still completed probe if the cio2_parse_firmware() function doesn't find any
> connected endpoints...but perhaps it should have behaved this way all along.
> Is there value in having the cio2 device probed, but useless? I can't think
> of any at the moment.
>
>
> The patch contents themselves look good to me.
Let's just leave it as-is if everyone is happy with the current
behavior. When someone complains, we'll fix it.
regards,
dan carpenter
next prev parent reply other threads:[~2024-05-14 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 15:43 [PATCH v2] media: ipu-bridge: fix error code in ipu_bridge_init() Dan Carpenter
2024-05-10 15:55 ` Andy Shevchenko
2024-05-14 10:14 ` Dan Scally
2024-05-14 14:06 ` Dan Carpenter [this message]
2024-05-14 14:33 ` Sakari Ailus
2024-05-14 15:21 ` Andy Shevchenko
2024-05-14 15:38 ` Hans de Goede
2024-05-22 12:03 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2d48c85-9cfe-41af-ac43-d61bb1be4dc3@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=dan.scally@ideasonboard.com \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).