* Re: [PATCH] ata: ahci_ceva: return of_property_read_u8_array() error code
[not found] <1710960665-1391654-1-git-send-email-radhey.shyam.pandey@amd.com>
@ 2024-03-21 9:22 ` Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2024-03-21 9:22 UTC (permalink / raw
To: Radhey Shyam Pandey, linux-ide, kernel-janitors, git,
Damien Le Moal, Niklas Cassel
Cc: LKML, Jens Axboe, Michal Simek, Peter Zijlstra, Philipp Zabel
> In the ahci_ceva_probe() error path instead of returning -EINVAL for all
> of_property_read_u8_array() failure types return the actual error code.
> It removes the redundant -EINVAL assignment at multiple places and
> improves the error handling path.
A) Would a change description be more desirable with a corresponding imperative wording?
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.8#n94
B) Can it be helpful to specify the hint “in ceva_ahci_probe()” at the end
of the patch subject?
C) How do you think about to extend the application of scope-based resource management here?
See also:
Article by Jonathan Corbet
2023-06-15
https://lwn.net/Articles/934679/
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-03-21 9:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1710960665-1391654-1-git-send-email-radhey.shyam.pandey@amd.com>
2024-03-21 9:22 ` [PATCH] ata: ahci_ceva: return of_property_read_u8_array() error code Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).