From: Stephen Boyd <sboyd@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Abel Vesa <abel.vesa@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] spmi: pmic-arb: Fix of_irq_get_byname() error checking
Date: Thu, 02 May 2024 15:24:31 -0700 [thread overview]
Message-ID: <a88f34f36ef5ad8fbcb1343a9ce79823.sboyd@kernel.org> (raw)
In-Reply-To: <dba8658a-f13f-4fde-b610-57a391b0a1c2@moroto.mountain>
Quoting Dan Carpenter (2024-05-02 00:08:29)
> On Wed, May 01, 2024 at 05:55:03PM -0700, Stephen Boyd wrote:
> > Quoting Dan Carpenter (2024-04-24 04:42:46)
> > > There are two bugs in this code:
> > > 1) The "irq" variable needs to be signed for the error handling to
> > > work.
> > > 2) The of_irq_get_byname() also returns zero on error so change the
> > > comparison from < 0 to <= 0.
> > >
> > > Fixes: 932282f154ac ("spmi: pmic-arb: Register controller for bus instead of arbiter")
> >
> > Sadly this isn't stable because I just send patches over email.
> >
>
> If you're going to send these as email then you should fold it into the
> original commit or otherwise people will be confused.
I removed the fixes tag. I will fold it in with your SoB, thanks!
prev parent reply other threads:[~2024-05-02 22:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 11:42 [PATCH] spmi: pmic-arb: Fix of_irq_get_byname() error checking Dan Carpenter
2024-05-02 0:55 ` Stephen Boyd
2024-05-02 7:08 ` Dan Carpenter
2024-05-02 22:24 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a88f34f36ef5ad8fbcb1343a9ce79823.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).