From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: intel: Constify struct snd_soc_ops
Date: Mon, 13 May 2024 08:41:55 -0500 [thread overview]
Message-ID: <88e6bbe3-94a2-4b50-b462-eb27376698c4@linux.intel.com> (raw)
In-Reply-To: <242aef53b5b9533ae4cca78148622f5fe752b7ee.1715452901.git.christophe.jaillet@wanadoo.fr>
On 5/11/24 13:42, Christophe JAILLET wrote:
> Constifying "struct snd_soc_ops" moves some data to a read-only section, so
> increase overall security.
>
> This structure is also part of scripts/const_structs.checkpatch.
>
> As an example, on a x86_64, with allmodconfig:
> Before:
> text data bss dec hex filename
> 6315 3696 0 10011 271b sound/soc/intel/boards/ehl_rt5660.o
>
> After:
> text data bss dec hex filename
> 6379 3648 0 10027 272b sound/soc/intel/boards/ehl_rt5660.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only.
>
> I hope that it can be applied with this single patch because all files are
> in sound/soc/intel/boards/
Doesn't apply for me, can you rebase and resend?
CONFLICT (content): Merge conflict in
sound/soc/intel/boards/sof_maxim_common.h
Auto-merging sound/soc/intel/boards/sof_maxim_common.c
CONFLICT (content): Merge conflict in
sound/soc/intel/boards/sof_maxim_common.c
error: Failed to merge in the changes.
Probably a result of all the changes in this directory...
Thanks!
prev parent reply other threads:[~2024-05-13 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 18:42 [PATCH] ASoC: intel: Constify struct snd_soc_ops Christophe JAILLET
2024-05-13 13:41 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88e6bbe3-94a2-4b50-b462-eb27376698c4@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).