From: "Paul E. McKenney" <paulmck@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: John Stultz <jstultz@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
David Riley <davidriley@chromium.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] time: add MODULE_DESCRIPTION() to time test modules
Date: Fri, 10 May 2024 21:31:57 -0700 [thread overview]
Message-ID: <779507fe-8794-47f8-9c9c-9dbd5cbe899f@paulmck-laptop> (raw)
In-Reply-To: <20240510-time-md-v1-1-44a8a36ac4b0@quicinc.com>
On Fri, May 10, 2024 at 05:24:25PM -0700, Jeff Johnson wrote:
> Fix the make W=1 warnings:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/clocksource-wdtest.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/test_udelay.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/time/time_test.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
From a clocksource-watchdog-test perspective:
Acked-by: Paul E. McKenney <paulmck@kernel.org>
> ---
> kernel/time/clocksource-wdtest.c | 1 +
> kernel/time/test_udelay.c | 1 +
> kernel/time/time_test.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/kernel/time/clocksource-wdtest.c b/kernel/time/clocksource-wdtest.c
> index d06185e054ea..62e73444ffe4 100644
> --- a/kernel/time/clocksource-wdtest.c
> +++ b/kernel/time/clocksource-wdtest.c
> @@ -22,6 +22,7 @@
> #include "tick-internal.h"
>
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Clocksource watchdog unit test");
> MODULE_AUTHOR("Paul E. McKenney <paulmck@kernel.org>");
>
> static int holdoff = IS_BUILTIN(CONFIG_TEST_CLOCKSOURCE_WATCHDOG) ? 10 : 0;
> diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c
> index 20d5df631570..783f2297111b 100644
> --- a/kernel/time/test_udelay.c
> +++ b/kernel/time/test_udelay.c
> @@ -155,5 +155,6 @@ static void __exit udelay_test_exit(void)
>
> module_exit(udelay_test_exit);
>
> +MODULE_DESCRIPTION("udelay test module");
> MODULE_AUTHOR("David Riley <davidriley@chromium.org>");
> MODULE_LICENSE("GPL");
> diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
> index 3e5d422dd15c..2889763165e5 100644
> --- a/kernel/time/time_test.c
> +++ b/kernel/time/time_test.c
> @@ -96,4 +96,5 @@ static struct kunit_suite time_test_suite = {
> };
>
> kunit_test_suite(time_test_suite);
> +MODULE_DESCRIPTION("time unit test suite");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: dd5a440a31fae6e459c0d6271dddd62825505361
> change-id: 20240510-time-md-0f1514019230
>
prev parent reply other threads:[~2024-05-11 4:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 0:24 [PATCH] time: add MODULE_DESCRIPTION() to time test modules Jeff Johnson
2024-05-11 4:31 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=779507fe-8794-47f8-9c9c-9dbd5cbe899f@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=davidriley@chromium.org \
--cc=jstultz@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).