From: Markus Elfring <Markus.Elfring@web.de>
To: Lee Jones <lee@kernel.org>,
wangkaiyuan@inspur.com, kernel-janitors@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: mfd: axp20x: convert to use maple tree register cache
Date: Thu, 2 May 2024 12:41:04 +0200 [thread overview]
Message-ID: <6f1fbc13-af76-4e24-a788-b5c2a52aa519@web.de> (raw)
In-Reply-To: <20240502093316.GI5338@google.com>
>>> The maple tree register cache is based on a much more modern data structure
>>> than the rbtree cache and makes optimisation choices which are probably
>>> more appropriate for modern systems than those made by the rbtree cache.
>>
>> Please choose another imperative wording for an improved change description.
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n94
>
> This review comment is seldom helpful.
* Does such a feedback indicate a questionable communication conflict?
* Are you still looking for a better wording suggestion?
> You may as well stop using it.
Should patch reviewers and further contributors care more for the compliance
with known development processes?
Regards,
Markus
prev parent reply other threads:[~2024-05-02 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240429024547.27724-1-wangkaiyuan@inspur.com>
2024-04-29 7:12 ` [PATCH] mfd: axp20x: convert to use maple tree register cache Markus Elfring
2024-05-02 9:33 ` Lee Jones
2024-05-02 10:41 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f1fbc13-af76-4e24-a788-b5c2a52aa519@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangkaiyuan@inspur.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).