* [PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll
@ 2024-04-01 15:31 Christophe JAILLET
2024-04-03 19:42 ` Vladimir Zapolskiy
2024-04-04 15:45 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2024-04-01 15:31 UTC (permalink / raw
To: Michael Turquette, Stephen Boyd, Vladimir Zapolskiy
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-clk,
linux-arm-kernel
In "struct lpc18xx_pll", the 'lock' field is unused.
Remove it.
Found with cppcheck, unusedStructMember.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.
---
drivers/clk/nxp/clk-lpc18xx-cgu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/nxp/clk-lpc18xx-cgu.c b/drivers/clk/nxp/clk-lpc18xx-cgu.c
index 69ebf65081b8..81efa885069b 100644
--- a/drivers/clk/nxp/clk-lpc18xx-cgu.c
+++ b/drivers/clk/nxp/clk-lpc18xx-cgu.c
@@ -250,7 +250,6 @@ static struct lpc18xx_cgu_base_clk lpc18xx_cgu_base_clks[] = {
struct lpc18xx_pll {
struct clk_hw hw;
void __iomem *reg;
- spinlock_t *lock;
u8 flags;
};
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll
2024-04-01 15:31 [PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll Christophe JAILLET
@ 2024-04-03 19:42 ` Vladimir Zapolskiy
2024-04-04 15:45 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Zapolskiy @ 2024-04-03 19:42 UTC (permalink / raw
To: Christophe JAILLET, Michael Turquette, Stephen Boyd
Cc: linux-kernel, kernel-janitors, linux-clk, linux-arm-kernel
On 4/1/24 18:31, Christophe JAILLET wrote:
> In "struct lpc18xx_pll", the 'lock' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thank you for the change!
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll
2024-04-01 15:31 [PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll Christophe JAILLET
2024-04-03 19:42 ` Vladimir Zapolskiy
@ 2024-04-04 15:45 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2024-04-04 15:45 UTC (permalink / raw
To: Christophe JAILLET, Michael Turquette, Vladimir Zapolskiy
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-clk,
linux-arm-kernel
Quoting Christophe JAILLET (2024-04-01 08:31:53)
> In "struct lpc18xx_pll", the 'lock' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-04 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-01 15:31 [PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll Christophe JAILLET
2024-04-03 19:42 ` Vladimir Zapolskiy
2024-04-04 15:45 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).