From: Markus Elfring <Markus.Elfring@web.de>
To: Yongzhi Liu <hyperlyzcs@gmail.com>,
GR-QLogic-Storage-Upstream@marvell.com,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Nilesh Javali <njavali@marvell.com>,
Saurav Kashyap <skashyap@marvell.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
huntazhang@tencent.com, jitxie@tencent.com
Subject: Re: [PATCH] scsi: qla2xxx: Fix double free of fcport in error handling path
Date: Thu, 25 Apr 2024 13:31:02 +0200 [thread overview]
Message-ID: <443fb75b-948b-430f-be33-170e6f592280@web.de> (raw)
In-Reply-To: <20240425093744.22207-1-hyperlyzcs@gmail.com>
…
> Fix this by cleaning up the redundant qla2x00_free_fcport().
…
I suggest to avoid duplicate error handling code a bit more
also for the implementation of the function “qla24xx_els_dcmd_iocb”.
https://elixir.bootlin.com/linux/v6.9-rc5/source/drivers/scsi/qla2xxx/qla_iocb.c#L2751
See also:
https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources
Regards,
Markus
next parent reply other threads:[~2024-04-25 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240425093744.22207-1-hyperlyzcs@gmail.com>
2024-04-25 11:31 ` Markus Elfring [this message]
[not found] ` <20240428113404.12522-1-hyperlyzcs@gmail.com>
2024-04-28 12:52 ` [PATCH V2] scsi: qla2xxx: Fix double free of fcport in error handling path Markus Elfring
2024-04-29 5:12 ` Markus Elfring
[not found] ` <20240430091144.10744-1-hyperlyzcs@gmail.com>
2024-04-30 9:55 ` [PATCH V3 1/2] scsi: qla2xxx: Fix double free of fcport in qla24xx_els_dcmd_iocb Markus Elfring
[not found] ` <20240430091144.10744-2-hyperlyzcs@gmail.com>
2024-04-30 11:21 ` [PATCH V3 2/2] scsi: qla2xxx: Optimisation of exception handling " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443fb75b-948b-430f-be33-170e6f592280@web.de \
--to=markus.elfring@web.de \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=himanshu.madhani@oracle.com \
--cc=huntazhang@tencent.com \
--cc=hyperlyzcs@gmail.com \
--cc=jitxie@tencent.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
--cc=skashyap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).