From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Peter Rosin <peda@axentia.se>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: multiplexer: Remove an unused field in struct mux
Date: Sat, 4 May 2024 12:41:31 +0100 [thread overview]
Message-ID: <20240504124131.6c6e3e8e@jic23-huawei> (raw)
In-Reply-To: <7bb04abdc2815caf090a6c9ecab2a51d837792a7.1714556499.git.christophe.jaillet@wanadoo.fr>
On Wed, 1 May 2024 11:41:54 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> In "struct mux", the 'indio_dev' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied,
Thanks,
> ---
> Compile tested only.
>
> It was added in the initial commit 7ba9df54b091 ("iio: multiplexer: new iio
> category and iio-mux driver") but was never used.
> ---
> drivers/iio/multiplexer/iio-mux.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
> index edd8c69f6d2e..2953403bef53 100644
> --- a/drivers/iio/multiplexer/iio-mux.c
> +++ b/drivers/iio/multiplexer/iio-mux.c
> @@ -30,7 +30,6 @@ struct mux {
> int cached_state;
> struct mux_control *control;
> struct iio_channel *parent;
> - struct iio_dev *indio_dev;
> struct iio_chan_spec *chan;
> struct iio_chan_spec_ext_info *ext_info;
> struct mux_child *child;
prev parent reply other threads:[~2024-05-04 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 9:41 [PATCH] iio: multiplexer: Remove an unused field in struct mux Christophe JAILLET
2024-05-04 11:41 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240504124131.6c6e3e8e@jic23-huawei \
--to=jic23@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).