From: Lee Jones <lee@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Pavel Machek <pavel@ucw.cz>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] leds: mt6370: Remove an unused field in struct mt6370_priv
Date: Thu, 2 May 2024 18:14:51 +0100 [thread overview]
Message-ID: <20240502171451.GE1200070@google.com> (raw)
In-Reply-To: <d526b169-0385-4f23-8806-17bc73c2507b@wanadoo.fr>
On Mon, 29 Apr 2024, Christophe JAILLET wrote:
> Le 29/04/2024 à 10:13, AngeloGioacchino Del Regno a écrit :
> > Il 28/04/24 20:27, Christophe JAILLET ha scritto:
> > > In "struct mt6370_priv", the 'reg_cfgs' field is unused.
> > >
> > > Moreover the "struct reg_cfg" is defined nowhere. Neither in this
> > > file, nor
> > > in a global .h file, so it is completely pointless.
> > >
> > > Remove it.
> >
> > Sure
> >
> > >
> > > Found with cppcheck, unusedStructMember.
> > >
> > > So, remove it.
> >
> > Again?! :-P
>
> Yes. This way we safe twice the memory space :).
I changed all of the commit messages in this disjointed set to flow a
little better. No need for a Fixes tag either I feel.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-05-02 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 18:27 [PATCH] leds: mt6370: Remove an unused field in struct mt6370_priv Christophe JAILLET
2024-04-29 8:13 ` AngeloGioacchino Del Regno
2024-04-29 18:31 ` Christophe JAILLET
2024-05-02 17:14 ` Lee Jones [this message]
2024-05-02 17:13 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502171451.GE1200070@google.com \
--to=lee@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).