* [PATCH 1/2] octeontx2-pf: check negative error code in otx2_open()
@ 2024-03-25 7:35 Su Hui
2024-03-25 7:35 ` [PATCH 2/2] octeontx2-pf: remove unused variables req_hdr and rsp_hdr Su Hui
2024-03-25 12:42 ` [EXTERNAL] [PATCH 1/2] octeontx2-pf: check negative error code in otx2_open() Subbaraya Sundeep Bhatta
0 siblings, 2 replies; 5+ messages in thread
From: Su Hui @ 2024-03-25 7:35 UTC (permalink / raw
To: sgoutham, gakula, sbhatta, hkelam, davem, edumazet, kuba, pabeni
Cc: Su Hui, saikrishnag, netdev, linux-kernel, kernel-janitors
otx2_rxtx_enable() return negative error code such as -EIO,
check -EIO rather than EIO to fix this problem.
Fixes: c926252205c4 ("octeontx2-pf: Disable packet I/O for graceful exit")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
index b40bd0e46751..3f46d5e0fb2e 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
@@ -1933,7 +1933,7 @@ int otx2_open(struct net_device *netdev)
* mcam entries are enabled to receive the packets. Hence disable the
* packet I/O.
*/
- if (err == EIO)
+ if (err == -EIO)
goto err_disable_rxtx;
else if (err)
goto err_tx_stop_queues;
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] octeontx2-pf: remove unused variables req_hdr and rsp_hdr
2024-03-25 7:35 [PATCH 1/2] octeontx2-pf: check negative error code in otx2_open() Su Hui
@ 2024-03-25 7:35 ` Su Hui
2024-03-25 12:44 ` [EXTERNAL] " Subbaraya Sundeep Bhatta
2024-03-25 12:42 ` [EXTERNAL] [PATCH 1/2] octeontx2-pf: check negative error code in otx2_open() Subbaraya Sundeep Bhatta
1 sibling, 1 reply; 5+ messages in thread
From: Su Hui @ 2024-03-25 7:35 UTC (permalink / raw
To: sgoutham, gakula, sbhatta, hkelam, davem, edumazet, kuba, pabeni,
nathan, ndesaulniers, morbo, justinstitt
Cc: Su Hui, netdev, linux-kernel, llvm, kernel-janitors
Clang static checker(scan-buid):
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:503:2: warning:
Value stored to 'rsp_hdr' is never read [deadcode.DeadStores]
Remove these unused variables to save some space.
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
index 3f46d5e0fb2e..637b05c79c42 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
@@ -450,7 +450,6 @@ static void otx2_pfvf_mbox_handler(struct work_struct *work)
struct mbox_msghdr *msg = NULL;
int offset, vf_idx, id, err;
struct otx2_mbox_dev *mdev;
- struct mbox_hdr *req_hdr;
struct otx2_mbox *mbox;
struct mbox *vf_mbox;
struct otx2_nic *pf;
@@ -461,9 +460,8 @@ static void otx2_pfvf_mbox_handler(struct work_struct *work)
mbox = &pf->mbox_pfvf[0].mbox;
mdev = &mbox->dev[vf_idx];
- req_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->rx_start);
- offset = ALIGN(sizeof(*req_hdr), MBOX_MSG_ALIGN);
+ offset = ALIGN(sizeof(struct mbox_hdr), MBOX_MSG_ALIGN);
for (id = 0; id < vf_mbox->num_msgs; id++) {
msg = (struct mbox_msghdr *)(mdev->mbase + mbox->rx_start +
@@ -494,7 +492,6 @@ static void otx2_pfvf_mbox_up_handler(struct work_struct *work)
struct otx2_nic *pf = vf_mbox->pfvf;
struct otx2_mbox_dev *mdev;
int offset, id, vf_idx = 0;
- struct mbox_hdr *rsp_hdr;
struct mbox_msghdr *msg;
struct otx2_mbox *mbox;
@@ -502,8 +499,7 @@ static void otx2_pfvf_mbox_up_handler(struct work_struct *work)
mbox = &pf->mbox_pfvf[0].mbox_up;
mdev = &mbox->dev[vf_idx];
- rsp_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->rx_start);
- offset = mbox->rx_start + ALIGN(sizeof(*rsp_hdr), MBOX_MSG_ALIGN);
+ offset = mbox->rx_start + ALIGN(sizeof(struct mbox_hdr), MBOX_MSG_ALIGN);
for (id = 0; id < vf_mbox->up_num_msgs; id++) {
msg = mdev->mbase + offset;
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [EXTERNAL] [PATCH 1/2] octeontx2-pf: check negative error code in otx2_open()
2024-03-25 7:35 [PATCH 1/2] octeontx2-pf: check negative error code in otx2_open() Su Hui
2024-03-25 7:35 ` [PATCH 2/2] octeontx2-pf: remove unused variables req_hdr and rsp_hdr Su Hui
@ 2024-03-25 12:42 ` Subbaraya Sundeep Bhatta
1 sibling, 0 replies; 5+ messages in thread
From: Subbaraya Sundeep Bhatta @ 2024-03-25 12:42 UTC (permalink / raw
To: Su Hui, Sunil Kovvuri Goutham, Geethasowjanya Akula,
Hariprasad Kelam, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Cc: Sai Krishna Gajula, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
>-----Original Message-----
>From: Su Hui <suhui@nfschina.com>
>Sent: Monday, March 25, 2024 1:06 PM
>To: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
><gakula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>;
>Hariprasad Kelam <hkelam@marvell.com>; davem@davemloft.net;
>edumazet@google.com; kuba@kernel.org; pabeni@redhat.com
>Cc: Su Hui <suhui@nfschina.com>; Sai Krishna Gajula
><saikrishnag@marvell.com>; netdev@vger.kernel.org; linux-
>kernel@vger.kernel.org; kernel-janitors@vger.kernel.org
>Subject: [PATCH 1/2] octeontx2-pf: check negative error code in
>otx2_open()
>
>otx2_rxtx_enable() return negative error code such as -EIO,
>check -EIO rather than EIO to fix this problem.
>
>Fixes: c926252205c4 ("octeontx2-pf: Disable packet I/O for graceful exit")
>Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [EXTERNAL] [PATCH 2/2] octeontx2-pf: remove unused variables req_hdr and rsp_hdr
2024-03-25 7:35 ` [PATCH 2/2] octeontx2-pf: remove unused variables req_hdr and rsp_hdr Su Hui
@ 2024-03-25 12:44 ` Subbaraya Sundeep Bhatta
2024-03-25 15:36 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Subbaraya Sundeep Bhatta @ 2024-03-25 12:44 UTC (permalink / raw
To: Su Hui, Sunil Kovvuri Goutham, Geethasowjanya Akula,
Hariprasad Kelam, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org,
ndesaulniers@google.com, morbo@google.com, justinstitt@google.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, kernel-janitors@vger.kernel.org
Hi,
>-----Original Message-----
>From: Su Hui <suhui@nfschina.com>
>Sent: Monday, March 25, 2024 1:06 PM
>To: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
><gakula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>;
>Hariprasad Kelam <hkelam@marvell.com>; davem@davemloft.net;
>edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
>nathan@kernel.org; ndesaulniers@google.com; morbo@google.com;
>justinstitt@google.com
>Cc: Su Hui <suhui@nfschina.com>; netdev@vger.kernel.org; linux-
>kernel@vger.kernel.org; llvm@lists.linux.dev; kernel-janitors@vger.kernel.org
>Subject: [PATCH 2/2] octeontx2-pf: remove unused variables
>req_hdr and rsp_hdr
>
>Clang static checker(scan-buid):
>drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:503:2: warning:
>Value stored to 'rsp_hdr' is never read [deadcode.DeadStores]
>
Consider this also as a fix and add Fixes tag. Also please add "net" in subject to
easily identify whether this patch as net or net-next material.
Thanks,
Sundeep
>Remove these unused variables to save some space.
>
>Signed-off-by: Su Hui <suhui@nfschina.com>
>---
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>index 3f46d5e0fb2e..637b05c79c42 100644
>--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>@@ -450,7 +450,6 @@ static void otx2_pfvf_mbox_handler(struct
>work_struct *work)
> struct mbox_msghdr *msg = NULL;
> int offset, vf_idx, id, err;
> struct otx2_mbox_dev *mdev;
>- struct mbox_hdr *req_hdr;
> struct otx2_mbox *mbox;
> struct mbox *vf_mbox;
> struct otx2_nic *pf;
>@@ -461,9 +460,8 @@ static void otx2_pfvf_mbox_handler(struct
>work_struct *work)
>
> mbox = &pf->mbox_pfvf[0].mbox;
> mdev = &mbox->dev[vf_idx];
>- req_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->rx_start);
>
>- offset = ALIGN(sizeof(*req_hdr), MBOX_MSG_ALIGN);
>+ offset = ALIGN(sizeof(struct mbox_hdr), MBOX_MSG_ALIGN);
>
> for (id = 0; id < vf_mbox->num_msgs; id++) {
> msg = (struct mbox_msghdr *)(mdev->mbase + mbox->rx_start
>+
>@@ -494,7 +492,6 @@ static void otx2_pfvf_mbox_up_handler(struct
>work_struct *work)
> struct otx2_nic *pf = vf_mbox->pfvf;
> struct otx2_mbox_dev *mdev;
> int offset, id, vf_idx = 0;
>- struct mbox_hdr *rsp_hdr;
> struct mbox_msghdr *msg;
> struct otx2_mbox *mbox;
>
>@@ -502,8 +499,7 @@ static void otx2_pfvf_mbox_up_handler(struct
>work_struct *work)
> mbox = &pf->mbox_pfvf[0].mbox_up;
> mdev = &mbox->dev[vf_idx];
>
>- rsp_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->rx_start);
>- offset = mbox->rx_start + ALIGN(sizeof(*rsp_hdr),
>MBOX_MSG_ALIGN);
>+ offset = mbox->rx_start + ALIGN(sizeof(struct mbox_hdr),
>MBOX_MSG_ALIGN);
>
> for (id = 0; id < vf_mbox->up_num_msgs; id++) {
> msg = mdev->mbase + offset;
>--
>2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [EXTERNAL] [PATCH 2/2] octeontx2-pf: remove unused variables req_hdr and rsp_hdr
2024-03-25 12:44 ` [EXTERNAL] " Subbaraya Sundeep Bhatta
@ 2024-03-25 15:36 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2024-03-25 15:36 UTC (permalink / raw
To: Subbaraya Sundeep Bhatta
Cc: Su Hui, Sunil Kovvuri Goutham, Geethasowjanya Akula,
Hariprasad Kelam, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org,
ndesaulniers@google.com, morbo@google.com, justinstitt@google.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, kernel-janitors@vger.kernel.org
On Mon, Mar 25, 2024 at 12:44:44PM +0000, Subbaraya Sundeep Bhatta wrote:
> Hi,
>
> >-----Original Message-----
> >From: Su Hui <suhui@nfschina.com>
> >Sent: Monday, March 25, 2024 1:06 PM
> >To: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> ><gakula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>;
> >Hariprasad Kelam <hkelam@marvell.com>; davem@davemloft.net;
> >edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> >nathan@kernel.org; ndesaulniers@google.com; morbo@google.com;
> >justinstitt@google.com
> >Cc: Su Hui <suhui@nfschina.com>; netdev@vger.kernel.org; linux-
> >kernel@vger.kernel.org; llvm@lists.linux.dev; kernel-janitors@vger.kernel.org
> >Subject: [PATCH 2/2] octeontx2-pf: remove unused variables
> >req_hdr and rsp_hdr
> >
> >Clang static checker(scan-buid):
> >drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:503:2: warning:
> >Value stored to 'rsp_hdr' is never read [deadcode.DeadStores]
> >
> Consider this also as a fix and add Fixes tag. Also please add "net" in subject to
> easily identify whether this patch as net or net-next material.
>
It's not a bug fix so it doesn't need a Fixes tag.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-25 15:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-25 7:35 [PATCH 1/2] octeontx2-pf: check negative error code in otx2_open() Su Hui
2024-03-25 7:35 ` [PATCH 2/2] octeontx2-pf: remove unused variables req_hdr and rsp_hdr Su Hui
2024-03-25 12:44 ` [EXTERNAL] " Subbaraya Sundeep Bhatta
2024-03-25 15:36 ` Dan Carpenter
2024-03-25 12:42 ` [EXTERNAL] [PATCH 1/2] octeontx2-pf: check negative error code in otx2_open() Subbaraya Sundeep Bhatta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).