From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org,
Colin Ian King <colin.i.king@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] jbd2: remove redundant assignement to variable err
Date: Tue, 7 May 2024 19:03:49 -0400 [thread overview]
Message-ID: <171512302200.3602678.5356035160659391900.b4-ty@mit.edu> (raw)
In-Reply-To: <20240410112803.232993-1-colin.i.king@gmail.com>
On Wed, 10 Apr 2024 12:28:03 +0100, Colin Ian King wrote:
> The variable err is being assigned a value that is never read, it
> is being re-assigned inside the following while loop and also
> after the while loop. The assignment is redundant and can be
> removed.
>
> Cleans up clang scan build warning:
> fs/jbd2/commit.c:574:2: warning: Value stored to 'err' is never
> read [deadcode.DeadStores]
>
> [...]
Applied, thanks!
[1/1] jbd2: remove redundant assignement to variable err
commit: 8b57de1c5edde3faf8a4f6a440b7ec16bb3c81d4
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2024-05-07 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 11:28 [PATCH][next] jbd2: remove redundant assignement to variable err Colin Ian King
2024-04-10 12:05 ` Jan Kara
2024-05-07 23:03 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171512302200.3602678.5356035160659391900.b4-ty@mit.edu \
--to=tytso@mit.edu \
--cc=colin.i.king@gmail.com \
--cc=jack@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).