From: Gong Ruiqi <gongruiqi1@huawei.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Kees Cook <keescook@chromium.org>, Marco Elver <elver@google.com>
Cc: Xiu Jianfeng <xiujianfeng@huawei.com>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
Date: Wed, 29 Jun 2022 13:51:15 +0800 [thread overview]
Message-ID: <6c274345-3370-16c8-f5f1-68521de0f51a@huawei.com> (raw)
In-Reply-To: <ca0fa9d2-64dd-0e77-71b6-3673e353c316@csgroup.eu>
On 2022/06/29 13:10, Christophe Leroy wrote:
>
>
> Le 29/06/2022 à 05:29, GONG, Ruiqi a écrit :
>> Fix the following Sparse warnings that got noticed when the PPC-dev
>> patchwork was checking another patch (see the link below):
>>
>> init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
>> init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
>>
>> Which in fact are triggered on all architectures that have
>> HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
>> etc).
>>
>> Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
>> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>> Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
>> Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
>> ---
>> init/main.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/init/main.c b/init/main.c
>> index e2490387db2b..6aa0fb2340cc 100644
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -101,6 +101,10 @@
>> #include <linux/stackdepot.h>
>> #include <net/net_namespace.h>
>>
>> +#ifdef CONFIG_RANDOMIZE_KSTACK_OFFSET
>
> You don't need this #ifdef, there is already one inside
> linux/randomize_kstack.h
>
Ah yes, I didn't notice the config was there already. I will send a new
version. Thanks for your reminder!
>> +#include <linux/randomize_kstack.h>
>> +#endif
>> +
>> #include <asm/io.h>
>> #include <asm/bugs.h>
>> #include <asm/setup.h>
>> --
>> 2.25.1
prev parent reply other threads:[~2022-06-29 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 3:29 [PATCH] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings GONG, Ruiqi
2022-06-29 5:10 ` Christophe Leroy
2022-06-29 5:51 ` Gong Ruiqi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c274345-3370-16c8-f5f1-68521de0f51a@huawei.com \
--to=gongruiqi1@huawei.com \
--cc=christophe.leroy@csgroup.eu \
--cc=elver@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).