From: Daniel Gomez <da.gomez@samsung.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: "kdevops@lists.linux.dev" <kdevops@lists.linux.dev>,
Pankaj Raghav <p.raghav@samsung.com>,
"gost.dev@samsung.com" <gost.dev@samsung.com>
Subject: Re: [PATCH 1/1] linux: generate tags automatically
Date: Mon, 5 Feb 2024 12:08:52 +0000 [thread overview]
Message-ID: <ue3odmrpoipqrhr7xokwdoer6q3dkeztjmvlndh2r7msyxsyxn@6gomgf3rgwfb> (raw)
In-Reply-To: <ZbwbEInIAzrNV4fq@bombadil.infradead.org>
On Thu, Feb 01, 2024 at 02:28:32PM -0800, Luis Chamberlain wrote:
> On Thu, Feb 01, 2024 at 10:15:32PM +0000, Daniel Gomez wrote:
> > Generate a Kconfig choice/endchoice menu with a list of the latest git
> > refs (tags and heads) for upstream repositories.
> >
> > Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
>
> Overall, I think this is pretty awesome! Thoughts below on just
> loose things we should review to scale / grow so we can have
> expected behaviour in the future.
>
> > ---
> > diff --git a/workflows/linux/Kconfig b/workflows/linux/Kconfig
> > index e34d2253..5334fd07 100644
> > --- a/workflows/linux/Kconfig
> > +++ b/workflows/linux/Kconfig
> > @@ -220,9 +220,9 @@ config BOOTLINUX_TEST_MESSAGE_ID_INSTALL_B4
> >
> > config BOOTLINUX_TREE_TAG
> > string
> > - default BOOTLINUX_TREE_LINUS_TAG if BOOTLINUX_TREE_LINUS
> > - default BOOTLINUX_TREE_STABLE_TAG if BOOTLINUX_STABLE
> > - default BOOTLINUX_TREE_NEXT_TAG if BOOTLINUX_TREE_NEXT
> > + default BOOTLINUX_TREE_LINUS_REF if BOOTLINUX_TREE_LINUS
> > + default BOOTLINUX_TREE_STABLE_REF if BOOTLINUX_STABLE
> > + default BOOTLINUX_TREE_NEXT_REF if BOOTLINUX_TREE_NEXT
>
> We should discuss if we want or need a new choice for choosing whether
> or not we want the a) latest and greatest or b) last boot tested / build
> tested version. The difference being a) would likely be used to base
> tests on which move forward, and b) allows you to do less work to test
> the latest.
I think they don't need to be exclusive. We can have the script to generate
a) and some sort of template including b) that the script uses to generate the
final list of options.
I did a prototype of this for mcgrof-next and jlayton trees already. I can
polish it and send a v2 for review.
>
> The issue with keeping a choise for this is then we're back to having
> to update a tag when a new release is made, but the value for that is
> that you'd get a sensible default which we know at least works.
>
> I'm inclined to believe not having the option is best for now. It just
> means we'll also want to somehow extend fstests with a Kconfig (with the
> option enabled by default) so that if no baseline is found for a kernel,
> we'd use the next most recent one to the tree version. Ie if one exists
> for v6.8-rc2 but not for v6.8-rc3 and the latest tag is v6.8-r3 we'll
> want this feature to let us use the v6.8-rc2 baseline. It just means
> we have to write support for this but I think Amir has been dying for
> something like this for a while.
>
> Good stuff, excited to try it!
>
> Luis
I also found the script needs to be 'promoted' to the top Makefile to generate
the kconfig and have it available when the user selects the bootlinux config
option inside menuconfig.
In addition, we probably don't want the script to run always as it delays the
make execution.
If you have any additional ideas/problems/suggestions just let me know.
Note: I've also updated the cc list to point to the correct kdevops maillist.
Daniel
next parent reply other threads:[~2024-02-05 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240201221531.3149-1-da.gomez@samsung.com>
[not found] ` <CGME20240201221534eucas1p1effd482d1e66907d3ef62effda73a59c@eucas1p1.samsung.com>
[not found] ` <20240201221531.3149-2-da.gomez@samsung.com>
[not found] ` <ZbwbEInIAzrNV4fq@bombadil.infradead.org>
2024-02-05 12:08 ` Daniel Gomez [this message]
2024-02-06 23:29 ` [PATCH 1/1] linux: generate tags automatically Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ue3odmrpoipqrhr7xokwdoer6q3dkeztjmvlndh2r7msyxsyxn@6gomgf3rgwfb \
--to=da.gomez@samsung.com \
--cc=gost.dev@samsung.com \
--cc=kdevops@lists.linux.dev \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).