From: Jeff Layton <jlayton@kernel.org>
To: fan.ni@gmx.us
Cc: nmtadam.samsung@gmail.com, fan.ni@samsung.com,
kdevops@lists.linux.dev, mcgrof@kernel.org
Subject: Re: [PATCH] qemu-build: Fix variable nproc undefined error
Date: Fri, 25 Aug 2023 13:14:27 -0400 [thread overview]
Message-ID: <a2b316239da5c7f097dbd0e6328960c14b84313d.camel@kernel.org> (raw)
In-Reply-To: <20230825170829.2285624-1-fan.ni@gmx.us>
On Fri, 2023-08-25 at 10:08 -0700, fan.ni@gmx.us wrote:
> From: Fan Ni <fan.ni@gmx.us>
>
> When running make qemu-build, hit the issue (msg": "The task includes an
> option with an undefined variable. The error was: 'nproc' is undefined.
> 'nproc' is undefined\n\nThe error appears to be in ...").
>
> Fixed it by adding "build" tag to Get nproc.
>
> Suggested-by: Jeff Layton <jlayton@kernel.org>
> Signed-off-by: Fan Ni <fan.ni@samsung.com>
> ---
> playbooks/roles/build_qemu/tasks/main.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/playbooks/roles/build_qemu/tasks/main.yml b/playbooks/roles/build_qemu/tasks/main.yml
> index 6bd34cf4..d3427c56 100644
> --- a/playbooks/roles/build_qemu/tasks/main.yml
> +++ b/playbooks/roles/build_qemu/tasks/main.yml
> @@ -83,7 +83,7 @@
>
> - name: Get nproc
> command: "{{ num_jobs }}"
> - tags: [ 'qemu', 'configure' ]
> + tags: [ 'qemu', 'configure', 'build' ]
> register: nproc
> when:
> - build_qemu_now|bool
> --
> 2.40.1
>
Thanks! Pushed to master.
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2023-08-25 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 17:08 [PATCH] qemu-build: Fix variable nproc undefined error fan.ni
2023-08-25 17:14 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2b316239da5c7f097dbd0e6328960c14b84313d.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=fan.ni@gmx.us \
--cc=fan.ni@samsung.com \
--cc=kdevops@lists.linux.dev \
--cc=mcgrof@kernel.org \
--cc=nmtadam.samsung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).