From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: Chuck Lever <cel@kernel.org>,
"kdevops@lists.linux.dev" <kdevops@lists.linux.dev>
Subject: Re: [PATCH v2 5/7] Add a playbook for the git regression workflow
Date: Thu, 25 Jan 2024 08:17:40 -0800 [thread overview]
Message-ID: <ZbKJpIA21UYhlyZn@bombadil.infradead.org> (raw)
In-Reply-To: <48980CCA-75A5-4EF9-96A9-D1F124B846F3@oracle.com>
On Thu, Jan 25, 2024 at 04:12:46PM +0000, Chuck Lever III wrote:
>
> > On Jan 25, 2024, at 10:14 AM, Luis Chamberlain <mcgrof@kernel.org> wrote:
If it doesn't break, don't fix it will be my stance :P
> And this has been replaced with "prove" by a later patch.
I see!
> >> +# XXX: This is working now, but it should copy the failures into a log file
> >> +- name: Report failures
> >> + tags: [ 'copy_results' ]
> >> + debug:
> >> + msg: "{{ gitr_results.stderr_lines }}"
> >> + when: gitr_results.stderr | length > 0
> >
> > Curious, has this found issues on filesystems before?
>
> Absolutely. We find a problem using this test every second or
> third kernel release. It's the multi-threading that exposes
> the most interesting races, but sometimes a test failure can
> be reproduced with just one of these subtests.
>
> NFS has benefitted considerably, I think, because the git
> community themselves test pretty thoroughly on local
> filesystems but not on NFS mounts.
>
Great to know thanks!
> > I was not aware of the extensive set of tests on git's 'make test', it
> > certainly is a nice collection, and I can see it being very useful, but
> > I am just curious if it already has had history of finding some fs bugs.
> >
> > If so, we could certainly augment our fs testing to run these too after
> > running fstests.
>
> Yes I hope others find it useful. I think it's pretty relevant
> to ensure the kernel's preferred version control system is
> working reliably on the premier tier of filesystems. :-)
Fantastic, will do so and also suggest it to other folks!
> And maybe the git community might find the kdevops framework
> useful for their own CI needs, since it gives them quick
> access to test results on several filesystem implementations.
Indeed, hope they find it useful, thanks for doing this!
Luis
next prev parent reply other threads:[~2024-01-25 16:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 15:08 [PATCH v2 0/7] Add a git regression workflow Chuck Lever
2024-01-03 15:08 ` [PATCH v2 1/7] nfsd_add_export: Add an export_options variable Chuck Lever
2024-01-03 15:08 ` [PATCH v2 2/7] nfsd_add_export: Set fsid= on tmpfs exports Chuck Lever
2024-01-03 15:08 ` [PATCH v2 3/7] create_tmpfs: Enable mounting tmpfs file systems for testing Chuck Lever
2024-01-25 14:26 ` Luis Chamberlain
2024-01-25 14:39 ` Chuck Lever III
2024-01-25 15:44 ` Luis Chamberlain
2024-01-03 15:08 ` [PATCH v2 4/7] create_nfs_mount: Enable testing arbitrary NFS mounts Chuck Lever
2024-01-03 15:08 ` [PATCH v2 5/7] Add a playbook for the git regression workflow Chuck Lever
2024-01-25 14:34 ` Luis Chamberlain
2024-01-25 14:41 ` Luis Chamberlain
2024-01-25 15:14 ` Luis Chamberlain
2024-01-25 16:12 ` Chuck Lever III
2024-01-25 16:17 ` Luis Chamberlain [this message]
2024-01-03 15:08 ` [PATCH v2 6/7] Add a workflow for the git regression suite Chuck Lever
2024-01-25 15:39 ` Luis Chamberlain
2024-01-25 15:56 ` Luis Chamberlain
2024-01-03 15:09 ` [PATCH v2 7/7] gitr: Adjust the gen_hosts and gen_nodes playbooks Chuck Lever
2024-01-03 17:10 ` [PATCH v2 0/7] Add a git regression workflow Jeff Layton
2024-01-03 18:04 ` Chuck Lever III
2024-01-04 16:04 ` Chuck Lever III
2024-01-04 16:46 ` Jeff Layton
2024-01-04 18:19 ` Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbKJpIA21UYhlyZn@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).