From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: Jeff Layton <jlayton@kernel.org>, Chuck Lever <cel@kernel.org>,
"kdevops@lists.linux.dev" <kdevops@lists.linux.dev>
Subject: Re: [PATCH RFC] bringup: Add soft iWARP bring-up option
Date: Thu, 25 Jan 2024 11:26:33 -0800 [thread overview]
Message-ID: <ZbK16UVL9Czkgtc3@bombadil.infradead.org> (raw)
In-Reply-To: <917B02B8-F8E3-49A6-B1CA-781771454D41@oracle.com>
On Thu, Jan 25, 2024 at 07:21:53PM +0000, Chuck Lever III wrote:
>
>
> > On Jan 25, 2024, at 11:46 AM, Luis Chamberlain <mcgrof@kernel.org> wrote:
> >
> > On Thu, Jan 25, 2024 at 04:35:02PM +0000, Chuck Lever III wrote:
> >>
> >>
> >>> On Jan 25, 2024, at 11:28 AM, Luis Chamberlain <mcgrof@kernel.org> wrote:
> >>>
> >>> On Thu, Jan 25, 2024 at 04:23:18PM +0000, Chuck Lever III wrote:
> >>>>
> >>>> My main review concern is the insertion of the udev rule.
> >>>> I hope that is OK with folks (ie: Luis).
> >>>
> >>> My only suggestion would be to define a variable for the ethernet
> >>> device instead, and then use {{ network_dev }} or whatever. I'm
> >>> surprised we don't yet have that defined, so either way it would
> >>> likely be useful one way or another in the future.
> >>
> >> I had looked for a way to grab the device name from the host
> >> or from Ansible before creating the siw device, but that got
> >> lost during development. I'll dig that up.
> >
> > Ah, yeah ansible might already have that as a fact, neat.
>
> For those playing at home, the one I found was:
>
> {{ ansible_default_ipv4.interface }}
Neat works for me!
Luis
prev parent reply other threads:[~2024-01-25 19:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 2:25 [PATCH RFC] bringup: Add soft iWARP bring-up option Chuck Lever
2024-01-25 13:26 ` Jeff Layton
2024-01-25 16:23 ` Chuck Lever III
2024-01-25 16:28 ` Luis Chamberlain
2024-01-25 16:35 ` Chuck Lever III
2024-01-25 16:46 ` Luis Chamberlain
2024-01-25 19:21 ` Chuck Lever III
2024-01-25 19:26 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbK16UVL9Czkgtc3@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).