From: Luis Chamberlain <mcgrof@kernel.org>
To: Jim Harris <jim.harris@samsung.com>
Cc: "kdevops@lists.linux.dev" <kdevops@lists.linux.dev>
Subject: Re: [PATCH] cxl: update config
Date: Wed, 6 Dec 2023 18:27:31 -0800 [thread overview]
Message-ID: <ZXEtk0E+7UFW6rug@bombadil.infradead.org> (raw)
In-Reply-To: <170188964507.476637.11457405266411915060.stgit@bgt-140510-bm01.eng.stellus.in>
On Wed, Dec 06, 2023 at 07:07:25PM +0000, Jim Harris wrote:
> diff --git a/defconfigs/cxl-switch b/defconfigs/cxl-switch
> index 6694f53c..c5f89155 100644
> --- a/defconfigs/cxl-switch
> +++ b/defconfigs/cxl-switch
> @@ -20,6 +25,8 @@ CONFIG_WORKFLOWS_LINUX_TESTS=y
> CONFIG_WORKFLOWS_DEDICATED_WORKFLOW=n
> CONFIG_KDEVOPS_WORKFLOW_NOT_DEDICATED_ENABLE_CXL=y
> CONFIG_KDEVOPS_WORKFLOW_ENABLE_CXL=y
> -CONFIG_BOOTLINUX_TEST_MESSAGE_ID=y
> -CONFIG_BOOTLINUX_TEST_MESSAGE_ID_THREAD_ID="20230719091931.27799-1-Jonathan.Cameron@huawei.com"
> -CONFIG_KDEVOPS_HOSTS_PREFIX="demo"
> +CONFIG_KDEVOPS_HOSTS_PREFIX="cxl"
Up to here it seems very sensible with the subject.
> +CONFIG_LIBVIRT_STORAGE_POOL_PATH_CUSTOM_MANUAL=y
> +CONFIG_LIBVIRT_STORAGE_POOL_PATH_CUSTOM="~/kdevops/images"
> +CONFIG_KDEVOPS_STORAGE_POOL_PATH="~/kdevops/images"
> +CONFIG_LOCAL_DEVELOPMENT_PATH="~/kdevops/devel"
This however is taking a huge leap about preference for how a system
wants to use storage for kdevops. It is fine the way these are used
will be documented with this included, but I figured I'd red-flag it
for now, in case folks want to reconsider this.
Maybe a future cxl-switch-simple-storage which includes the first one
and augments with the simple storage stuff ?
Storage pool setup is certainly a pain for many users so having
a neat solution to figure this setup up for a first time user
would be nice. It is just not clear what that should be.
Anyway, for now I just merged and pushed! Thanks!
Luis
prev parent reply other threads:[~2023-12-07 2:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231206190726uscas1p222cb866cacec1ee9880f560150a687b6@uscas1p2.samsung.com>
2023-12-06 19:07 ` [PATCH] cxl: update config Jim Harris
2023-12-07 2:27 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXEtk0E+7UFW6rug@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=jim.harris@samsung.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).