From: Luis Chamberlain <mcgrof@kernel.org>
To: Ross Vandegrift <ross@kallisti.us>
Cc: kdevops@lists.linux.dev
Subject: Re: [PATCH 1/2] add kconfig/ansible options for arm64 support
Date: Tue, 5 Sep 2023 13:04:22 -0700 [thread overview]
Message-ID: <ZPeJxiCry2CeUQt3@bombadil.infradead.org> (raw)
In-Reply-To: <20230904045740.mbsp7nbd6oxtdtid@stgulik.kallisti.us>
On Sun, Sep 03, 2023 at 09:57:40PM -0700, Ross Vandegrift wrote:
> On Fri, Sep 01, 2023 at 12:57:21PM -0700, Luis Chamberlain wrote:
> > On Thu, Aug 31, 2023 at 10:03:54PM -0700, Ross Vandegrift wrote:
> > > +libvirt_graphics_type: vnc
> > > +libvirt_loader: ""
> > > +libvirt_nvram_dir: /var/lib/libvirt/qemu/nvram
> >
> > this too.
>
> I'm not sure about this one. `loader` works on any platform afaik. On amd64,
> qemu's default searches and finds the firmware. On arm64, it doesn't search,
> or the search fails (not sure which). But the parameter is available on either
> arch.
Ah OK!
> `nvram` is similar. On arm64, I can't boot without specifying a file. On
> amd64, guests work without it. But it is allowed - compare `QEMU with UEFI
> manual firmware and secure boot` and `QEMU with UEFI manual firmware, secure
> boot and with NVRAM type 'file'` at:
> https://libvirt.org/formatdomain.html#bios-bootloader
>
> This made me think there could be cases where and amd64 user might need to
> override these. But this is outside of my wheelhouse, so I don't know any real
> use-cases.
These little nuggets are extremely useful obscure docs which we could
add as Kconfig, but only if you are willing to go through the trouble
of adding a Kconfig entry for this just for that. Otherwise a simple
default to empty with an override for ARM is fine for now.
> If you'd prefer them only available on arm64 I'm happy to make that
> change.
The minimum work then is a default empty with an override for arm64.
If you want to do more work which may be helpful for others to document
the use case in Kconfig why this is also available for non-arm64. Up to
you!
Luis
prev parent reply other threads:[~2023-09-05 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 5:03 [PATCH 1/2] add kconfig/ansible options for arm64 support Ross Vandegrift
2023-09-01 5:03 ` [PATCH 2/2] add kconfig for opensuse arm64 vagrant images Ross Vandegrift
2023-09-01 19:57 ` [PATCH 1/2] add kconfig/ansible options for arm64 support Luis Chamberlain
2023-09-04 4:57 ` Ross Vandegrift
2023-09-05 20:04 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPeJxiCry2CeUQt3@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=kdevops@lists.linux.dev \
--cc=ross@kallisti.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).