From: Chuck Lever III <chuck.lever@oracle.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: "kdevops@lists.linux.dev" <kdevops@lists.linux.dev>
Subject: Re: [PATCH] bringup: fix the soft iWARP bringup
Date: Fri, 26 Jan 2024 17:20:27 +0000 [thread overview]
Message-ID: <DE3A125B-0AA0-4772-9599-54CFE3848391@oracle.com> (raw)
In-Reply-To: <20240126165625.68669-1-jlayton@kernel.org>
> On Jan 26, 2024, at 11:56 AM, Jeff Layton <jlayton@kernel.org> wrote:
>
> It seemed like this worked for me at some point, but today it was
> failing to start for me. In any case, removing the ACTION= filter seemed
> to fix it for me.
Fair enough!
> Also, after reloading the udev rules, trigger them to be run so the
> siw interface is immediately started.
Distributions generally don't enable siw.ko (although some might
start doing so). Does the trigger cause that step to fail on
distribution kernels? If so, maybe that should be in another
step with a "failed: false" attribute.
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> playbooks/roles/siw/tasks/main.yml | 2 +-
> playbooks/roles/siw/templates/udev-rule.j2 | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/playbooks/roles/siw/tasks/main.yml b/playbooks/roles/siw/tasks/main.yml
> index f6d3f56136ed..be5aeb70be2c 100644
> --- a/playbooks/roles/siw/tasks/main.yml
> +++ b/playbooks/roles/siw/tasks/main.yml
> @@ -22,4 +22,4 @@
> - name: Force the target host to reload its udev ruleset
> become: yes
> become_method: sudo
> - ansible.builtin.command: "udevadm control --reload"
> + ansible.builtin.shell: "udevadm control --reload && udevadm trigger"
> diff --git a/playbooks/roles/siw/templates/udev-rule.j2 b/playbooks/roles/siw/templates/udev-rule.j2
> index 6fcaea6d1684..54f7beb6a764 100644
> --- a/playbooks/roles/siw/templates/udev-rule.j2
> +++ b/playbooks/roles/siw/templates/udev-rule.j2
> @@ -1,2 +1,2 @@
> -ACTION=="add", SUBSYSTEM=="net", KERNEL=="{{ ansible_default_ipv4.interface }}", \
> +SUBSYSTEM=="net", KERNEL=="{{ ansible_default_ipv4.interface }}", \
> PROGRAM="/usr/sbin/rdma link add siw0 type siw netdev {{ ansible_default_ipv4.interface }}"
> --
> 2.43.0
>
>
--
Chuck Lever
prev parent reply other threads:[~2024-01-26 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 16:56 [PATCH] bringup: fix the soft iWARP bringup Jeff Layton
2024-01-26 17:20 ` Chuck Lever III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE3A125B-0AA0-4772-9599-54CFE3848391@oracle.com \
--to=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).